Skip to content

NYL-22: Add Contact metadata and webhook parity - #340

Open
nylas-it-ops wants to merge 2 commits into
mainfrom
codex/NYL-22-contacts-sdk-parity
Open

NYL-22: Add Contact metadata and webhook parity#340
nylas-it-ops wants to merge 2 commits into
mainfrom
codex/NYL-22-contacts-sdk-parity

Conversation

@nylas-it-ops

Copy link
Copy Markdown
Contributor

Summary

  • add Contact metadata to response, create, and update models and builders
  • add indexed metadata_pair filtering with query serialization coverage
  • add contact.updated and contact.deleted webhook trigger constants and exact wire-name tests
  • document metadata semantics and iCloud/Yahoo webhook support boundaries

Test plan

  • ./gradlew test lintKotlin with the repository's Java 8 compiler toolchain (build successful)

@codecov-commenter

codecov-commenter commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.72%. Comparing base (5e0890b) to head (18a4682).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #340   +/-   ##
=========================================
  Coverage     83.72%   83.72%           
  Complexity      486      486           
=========================================
  Files            44       44           
  Lines          1358     1358           
  Branches        115      115           
=========================================
  Hits           1137     1137           
  Misses          149      149           
  Partials         72       72           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AaronDDM AaronDDM left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good morning! Strongest of the four SDK PRs — this is the only one with a real query-serialization test, and covering both create and update builders plus the exact wire names is the right level of detail.

Three notes below, none blocking. Approving.

Comment thread src/main/kotlin/com/nylas/models/WebhookTriggers.kt Outdated
Comment thread src/test/kotlin/com/nylas/resources/ContactsTests.kt Outdated
Comment thread src/test/kotlin/com/nylas/resources/WebhooksTests.kt Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants