gitsigns: use buf keymap option on Neovim 0.12.1+, fallback to buffer on older versions - #2161
Closed
dam9000 wants to merge 2 commits into
Closed
gitsigns: use buf keymap option on Neovim 0.12.1+, fallback to buffer on older versions#2161dam9000 wants to merge 2 commits into
buf keymap option on Neovim 0.12.1+, fallback to buffer on older versions#2161dam9000 wants to merge 2 commits into
Conversation
Follows the upstream rename of `buffer` to `buf` (neovim/neovim#38360, first shipped in v0.12.0); `buffer` is soft-deprecated, removal planned in v0.15. Fall back to `buffer` on older Neovim. The 0.12.1 floor (not 0.12.0) avoids distro snapshot builds like Ubuntu 25.10 `0.12.0~ubuntu1` (git snapshot d62bbe24cb), which reports `0.12.0-dev` but predates the `buf` support and rejects it with `invalid key: buf`.
dam9000
force-pushed
the
pr-gitsigns-buffer
branch
from
September 7, 2026 18:01
16e5f48 to
daff509
Compare
Collaborator
|
Sorry, but considering that we say that we only the support the latest stable version, and the fact that ubuntu 25.10 is already EOL since July 9th (because interim release are only supported for 9 month), I think it's best to just use I'm closing the PR for now, but if you strongly disagree I can reevaluate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent move from keymap.set buffer to buf broke neovim on ubuntu 25.10 with:
nvim on ubuntu 25.10 is: v0.12.0-dev
So recent enough but not quite 0.12.0 release - it's an earlier pre-release snapshot, so it breaks.
I think we could make an effort to keep the support of such a version, hence this PR.
There are 2 commits:
and: