deps: replace part of acorn with amaro - #66051
Open
avivkeller wants to merge 1 commit into
Open
avivkeller wants to merge 1 commit into
avivkeller wants to merge 1 commit into
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66051 +/- ##
=======================================
Coverage 90.23% 90.23%
=======================================
Files 789 789
Lines 270613 270527 -86
Branches 51801 51783 -18
=======================================
- Hits 244186 244120 -66
+ Misses 16885 16877 -8
+ Partials 9542 9530 -12
🚀 New features to boost your workflow:
|
Member
|
Can you include benchmarks result from this PR? |
Contributor
|
Why are there changes in |
aduh95
reviewed
Sep 16, 2026
Comment on lines
+459
to
+470
| function resolveRelativeInDeps(request, parentId) { | ||
| const { posix } = requireBuiltin('path'); | ||
| const id = posix.join(posix.dirname(parentId), request); | ||
| // Builtin ids do not carry the file extension. | ||
| if (StringPrototypeEndsWith(id, '.js')) { | ||
| return StringPrototypeSlice(id, 0, -3); | ||
| } | ||
| if (StringPrototypeEndsWith(id, '.mjs')) { | ||
| return StringPrototypeSlice(id, 0, -4); | ||
| } | ||
| return id; | ||
| } |
Contributor
There was a problem hiding this comment.
Shouldn't we vendor a bundle instead? Doing dynamic resolution is probably expansive, I don't think it's worth it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't 100% remove Acorn just yet, there a few kinks to be worked around, but we can replace some of it, which this PR does.
cc @marco-ippolito