Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
panva
reviewed
Sep 15, 2026
| # below, without ".js", followed by ": PASS,FLAKY". Example: | ||
| # sample-test : PASS,FLAKY | ||
|
|
||
| [true] # This section applies to all platforms |
Member
There was a problem hiding this comment.
we tend to keep this line even if it has no matches in it.
pmarchini
approved these changes
Sep 15, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66041 +/- ##
==========================================
- Coverage 90.23% 90.22% -0.01%
==========================================
Files 789 789
Lines 270613 270613
Branches 51794 51791 -3
==========================================
- Hits 244178 244159 -19
- Misses 16916 16926 +10
- Partials 9519 9528 +9 🚀 New features to boost your workflow:
|
panva
approved these changes
Sep 16, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pmarchini its place should have been in known_issues, we don't use skip for those. Anyways, it seems to me it's working fine, the test was wrongly flagging the output as invalid