Conversation
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
force-pushed
the
test-watch-flakes
branch
from
September 15, 2026 13:45
68dce3d to
cd6f523
Compare
test-run-watch-cwd-isolation-none-*
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66035 +/- ##
==========================================
+ Coverage 89.61% 90.24% +0.63%
==========================================
Files 789 789
Lines 270476 271428 +952
Branches 51619 51800 +181
==========================================
+ Hits 242393 244963 +2570
+ Misses 18449 16935 -1514
+ Partials 9634 9530 -104 🚀 New features to boost your workflow:
|
Member
|
Drop the |
panva
approved these changes
Sep 15, 2026
lpinca
approved these changes
Sep 15, 2026
Collaborator
Contributor
Author
Humpf failure on Windows |
Contributor
Author
|
I don't have a win-arm64 machine, and I wasn't able to reproduce to x86: > python.exe .\tools\test.py --shell=../v27.0.0-nightly2026090729667e046b/win-x64/node.exe --repeat 9999 test/test-runner/test-run-watch-cwd-isolation-none.mjs test/test-runner/test-run-watch-cwd-isolation-none-argv.mjs
[17:27|% 100|+ 19998|- 0]: DoneI guess I'll mark it as flaky on that platform and move on |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, on my machine:
With this PR:
Refs: #66056