Skip to content

tools: label PRs lacking second approval - #65538

Open
panva wants to merge 1 commit into
nodejs:mainfrom
panva:commit-queue-approval-label
Open

tools: label PRs lacking second approval#65538
panva wants to merge 1 commit into
nodejs:mainfrom
panva:commit-queue-approval-label

Conversation

@panva

@panva panva commented Aug 25, 2026

Copy link
Copy Markdown
Member

Pull requests in the commit queue that are at least two days old and lack a 2nd approval get labeled with lacks-second-approval. This makes it visible why the pull request has not landed yet and helps collaborators find pull requests that need another review.

Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva
panva requested a review from aduh95 August 25, 2026 10:43
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Aug 25, 2026
panva added a commit to nodejs/node-auto-test that referenced this pull request Aug 26, 2026
Enable the commit queue in node-auto-test.

Treat queued PRs as aged so PR 103 exercises the approval label.

PR-URL: nodejs/node#65538

Assisted-by: Codex
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva added a commit to nodejs/node-auto-test that referenced this pull request Aug 26, 2026
Enable the commit queue in node-auto-test.

Treat queued PRs as aged so PR 103 exercises the approval label.

PR-URL: nodejs/node#65538

Assisted-by: Codex
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva

panva commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Tested in nodejs/node-auto-test

@panva
panva marked this pull request as ready for review August 26, 2026 13:17
@panva panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants