deps: update V8 to 15.2 by targos · Pull Request #65161 · nodejs/node

targos · 2026-08-09T09:55:02Z

nodejs-github-bot · 2026-08-09T09:55:09Z

Review requested:

@nodejs/gyp
@nodejs/security-wg
@nodejs/v8

targos · 2026-08-09T20:25:44Z

I guess this is blocked by #64408 (https://github.com/nodejs/node/actions/runs/31307061482/job/93228984418?pr=65161)

joyeecheung · 2026-08-10T15:01:25Z

Uploaded https://chromium-review.googlesource.com/c/v8/v8/+/8223266 to fix the Linux AArch64 build (haven't tested on real Linux AArch64 yet, but that's what the error message suggests)

GCC requires SVE enabled for the entire translation unit and does not expose raw __builtin_sve_* builtins on a per-function basis. Fallback to Neon if it's not built by Clang. Refs: nodejs/node#65161 Change-Id: I53a06fcf8f901ae0347044c6999463ce99215c45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223266 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#109230}

Original commit message: [simd] Disable SVE implementation of array search for GCC GCC requires SVE enabled for the entire translation unit and does not expose raw __builtin_sve_* builtins on a per-function basis. Fallback to Neon if it's not built by Clang. Refs: nodejs#65161 Change-Id: I53a06fcf8f901ae0347044c6999463ce99215c45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223266 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#109230} Refs: v8/v8@68cf9ec

richardlau · 2026-08-13T12:28:07Z

FWIW https://chromium-review.googlesource.com/c/v8/v8/+/8236132 was opened by @sravani1510 to address the AIX build failure that is occurring on our V8 nightly builds.

targos · 2026-08-13T12:54:50Z

@nodejs/platform-windows We're hitting a weird error on Windows:

https://github.com/nodejs/node/actions/runs/31699320590/job/94444346312?pr=65161

  Unexpected command-line argument "src/debug/debug-wasm-obects.q", expected a .tq file.
C:\Program Files\Microsoft Visual Studio\18\Enterprise\MSBuild\Microsoft\VC\v180\Microsoft.CppCommon.targets(254,5): error MSB8066: Custom build for '..\..\out\Release\\torque.exe' exited with code 3. [D:\a\node\node\tools\v8_gypfiles\run_torque.vcxproj]

This wrong path doesn't exist in the code.

targos · 2026-08-13T15:25:23Z

@legendecas Can you help with the perfetto build?

legendecas · 2026-08-14T12:49:30Z

Fixed the perfetto build. But I think the CI is failing for tests in large pages. Likely not related.

targos · 2026-08-14T13:13:18Z

Thanks. Summary of the remaining issues in GitHub CI:

I'll start a Jenkins CI for more coverage.

nodejs-github-bot · 2026-08-14T13:21:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75841/

nodejs-github-bot · 2026-08-14T13:21:37Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7311/

nodejs-github-bot · 2026-08-14T13:22:07Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7311/

nodejs-github-bot · 2026-08-14T13:22:08Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7311/

richardlau · 2026-08-14T16:22:00Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7311/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7311/

Been talking to @miladfarca about this:

16:01:57 === mjsunit/maglev/regress-498816446-3 ===
16:01:57 --- stderr ---
16:01:57 V8 is running with experimental features enabled. Stability and security will suffer.
16:01:57 --- stdout ---
16:01:57 test/mjsunit/maglev/regress-498816446-3.js:25: RangeError: Array buffer allocation failed
16:01:57 ta = new Int32Array(0xffffffff+1);
16:01:57      ^
16:01:57 RangeError: Array buffer allocation failed
16:01:57     at new ArrayBuffer (<anonymous>)
16:01:57     at new Int32Array (<anonymous>)
16:01:57     at test/mjsunit/maglev/regress-498816446-3.js:25:6
16:01:57 Command: out.gn/s390x.release/d8 --test test/mjsunit/mjsunit.js test/mjsunit/maglev/regress-498816446-3.js --random-seed=-770474680 --nohard-abort --allow-natives-syntax --maglev-object-tracking --maglev
16:01:57 
16:01:57 ===
16:01:57 === 1 tests failed
16:01:57 ===
16:01:57 >>> 17287 base tests produced 15072 (87%) non-filtered tests
16:01:57 >>> 15072 tests ran

The Linux ppc64le and s390x machines being tested on have 8GB RAM and this test is allocating 16GB.

miladfarca · 2026-08-14T16:52:58Z

Patched it here: https://crrev.com/c/8252113

joyeecheung · 2026-08-19T22:29:03Z

For the SEA test failures: they should not have run in the first place. #63751 should fix it.

joyeecheung · 2026-08-20T02:21:07Z

This should fix the alpine failures https://chromium-review.googlesource.com/c/v8/v8/+/8254825

For most libcs, pthread_getattr_np() returns the the stack reserved limit on the main thread, but musl only returns the current high-water mark at the time of the call. There's no macro to detect musl, so just fallback to the conservative stack limit in cases where the libc is not one that is known to work. Refs: nodejs/node#65161 Change-Id: Ie2b51269b9e8d2d3451d5d68ad1a233d396af935 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8254825 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#109406}

Original commit message: [simd] Disable SVE implementation of array search for GCC GCC requires SVE enabled for the entire translation unit and does not expose raw __builtin_sve_* builtins on a per-function basis. Fallback to Neon if it's not built by Clang. Refs: nodejs#65161 Change-Id: I53a06fcf8f901ae0347044c6999463ce99215c45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8223266 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#109230} Refs: v8/v8@68cf9ec

Post-mortem libraries should use v8's debug_helper library instead. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

- Set/GetPrototype - Holder Signed-Off-By: Michaël Zasso <targos@protonmail.com> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

Signed-Off-By: Michaël Zasso <targos@protonmail.com> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

ICU_UTIL_DATA_SHARED had been removed since https://crrev.com/c/1513615, but Node.js still defined it and relied on the removed path on Windows, so the ICU initialization in mksnapshot had been silently failing since then. https://crrev.com/c/7679153 made the failure visible so the build started breaking on Windows. Fix it by always using ICU_UTIL_DATA_STATIC since we already compile the ICU data statically in. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

V8 bumped its wire-format version from 0x0f to 0x10. Update the expected hex in test-v8-serdes, and derive the v8 header bytes dynamically in test-runner-v8-deserializer so it tracks future bumps automatically. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

V8 no longer supports JSON.parse on worker isolates while the shared string table is enabled. Since --harmony-struct enables that table and Node workers parse process.config during bootstrap, use direct MessageChannel instead of a worker. Signed-Off-By: Michaël Zasso <targos@protonmail.com> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

Original commit message: [platform][posix] Fallback to conservative stack limit on musl For most libcs, pthread_getattr_np() returns the the stack reserved limit on the main thread, but musl only returns the current high-water mark at the time of the call. There's no macro to detect musl, so just fallback to the conservative stack limit in cases where the libc is not one that is known to work. Refs: nodejs#65161 Change-Id: Ie2b51269b9e8d2d3451d5d68ad1a233d396af935 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8254825 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#109406} Refs: v8/v8@ba4ef8d Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

Original commit message: Skip regress-498816446-3 when there is not enough memory Currently causing a test failure on a machine with 8Gb of memory: ``` regress-498816446-3.js:25: RangeError: Array buffer allocation failed ``` Change-Id: I9e0396445c0b870d0070d666f9d6081b93e80f9c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8252113 Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Reviewed-by: Darius Mercadier <dmercadier@chromium.org> Cr-Commit-Position: refs/heads/main@{#109426} Refs: v8/v8@811fe8b Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

Signed-off-by: StefanStojanovic <stefan.stojanovic@janeasystems.com> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

Original commit message: [cleanup] Remove --js-float16array Remove the --js-float16array flag and incorporate Float16Array into the standard typed array macros and baseline snapshot unconditionally. Float16Array has been shipping by default since M138. Bug: 548385945 TAG=agy CONV=052f499d-4ee5-4a10-8afd-900ba4a338db Change-Id: I2c0012158febf422fdc1b866b9414f3f040e83ad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8264275 Reviewed-by: Nikolaos Papaspyrou <nikolaos@chromium.org> Auto-Submit: Olivier Flückiger <olivf@chromium.org> Commit-Queue: Nikolaos Papaspyrou <nikolaos@chromium.org> Cr-Commit-Position: refs/heads/main@{#109335} Refs: v8/v8@f3d4d45 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#65702 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> r-li.patch Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

Original commit message: AIX: implement Stack::ObtainCurrentThreadStackReservedLimit Port 5a54f45b671bdf47e083ffbad547713d8bacb28f AIX lacks `pthread_getattr_np()` so we implement the function using pthread_getthrds_np() with PTHRDSINFO_QUERY_ALL, consistent with ObtainCurrentThreadStackStart(). The `__pi_stackaddr` field maps to the lowest stack address, equivalent to the base returned by pthread_attr_getstack() on other POSIX platforms. IT: 145 Change-Id: Ia1a34912630e3128f61fa0fca502429b837d611f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8236132 Reviewed-by: Milad Farazmand <mfarazma@ibm.com> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Cr-Commit-Position: refs/heads/main@{#109640} Refs: v8/v8@f4221e0 Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

Original commit message: Rewrite simdutf include paths to allow getting it from system Change-Id: I2b7b4cb452c22ed72e0935662c3c7477954bc205 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8319848 Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#109702} Refs: v8/v8@a0607c5 PR-URL: nodejs#65891 Reviewed-By: Xuguang Mei <meixuguang@gmail.com>

Original commit message: [base] Guard int8_t ReadUnalignedValue overload on Solaris On Solaris, int8_t is a typedef for char, so this overload collides with ReadUnalignedValue(const char*) and fails to compile. Guard it with V8_OS_SOLARIS, as already used elsewhere in the platform code. Introduced in: https://chromium-review.googlesource.com/c/v8/v8/+/7900500 Change-Id: I87c65412f412b6cf4de1f53ccaca539c1ce8c033 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8409815 Reviewed-by: Maya Lekova <mslekova@chromium.org> Reviewed-by: Anton Bikineev <bikineev@chromium.org> Reviewed-by: Joyee Cheung <joyee@igalia.com> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#110014} Refs: v8/v8@37baecd

Original commit message: Solaris: implement Stack::ObtainCurrentThreadStackReservedLimit Port 5a54f45b671bdf47e083ffbad547713d8bacb28f Solaris is excluded from the generic POSIX implementation, so implement the function using pthread_attr_get_np() and pthread_attr_getstack(), consistent with ObtainCurrentThreadStackStart(). The base returned by pthread_attr_getstack() maps to the lowest address of the thread's reserved stack. Change-Id: I08a5b4cd80180b04496b22989cb976d1c24ce8e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8413453 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Joyee Cheung <joyee@igalia.com> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#109953} Refs: v8/v8@315d9c9

Original commit message: [simd] Disable SVE implementation of array search for older ClangCL The Microsoft C++ ABI mangler in older ClangCL cannot mangle these built-ins. Disable SVE in this case. Refs: llvm/llvm-project#196170 Refs: nodejs#65161 Change-Id: I35e49dd4bfc0617bfa31cb7e3af1a475b4fb1bef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8420284 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#109945} Refs: v8/v8@820f3d7

Original commit message: [flags] compute kSortedFlagIndices at runtime in debug mode MSVC STL When compiling with MSVC STL in debug build, the computation exceeds its constexpr step limit. Switch to const instead in that case. Refs: nodejs#65161 Change-Id: I6e9e9b32052fc7ed2fe7f2453a24623c3e9da646 Refs: v8/v8@cc3ba9a

nodejs-github-bot · 2026-09-22T19:44:16Z

CI: https://ci.nodejs.org/job/node-test-pull-request/77763/

joyeecheung · 2026-09-22T19:45:04Z

Updated to 15.2.124.34, cherry-picked

and backported

https://chromium-review.googlesource.com/c/v8/v8/+/8413453 (landed in upstream)
https://chromium-review.googlesource.com/c/v8/v8/+/8409815 (landed in upstream)
https://chromium-review.googlesource.com/c/v8/v8/+/8420284 (landed in upstream)
https://chromium-review.googlesource.com/c/v8/v8/+/8421188 (still in upstream review)

targos · 2026-09-23T07:13:12Z

02:06:59 Failed to build addon in C:\workspace\node-test-binary-windows-native-suites\node\test\addons\cppgc-object:
02:06:59 
02:06:59 
02:06:59   binding.cc
02:06:59 
02:06:59 C:\Users\Administrator\AppData\Local\Temp\tmp8um0d2qk\include\node\cppgc\heap.h(40,37): error C3861: '__builtin_frame_address': identifier not found [C:\workspace\node-test-binary-windows-native-suites\node\test\addons\cppgc-object\build\binding.vcxproj]
02:06:59 
02:06:59   (compiling source file '../binding.cc')
02:06:59 
02:06:59   
02:06:59 
02:06:59 C:\workspace\node-test-binary-windows-native-suites\node\test\addons\cppgc-object\binding.cc(24,11): warning C4996: 'node::SetCppgcReference': Use v8::Object::Wrap() [C:\workspace\node-test-binary-windows-native-suites\node\test\addons\cppgc-object\build\binding.vcxproj]
02:06:59 
02:06:59 
02:06:59 (node:9804) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
02:06:59 (Use `node --trace-deprecation ...` to show where the warning was created)
02:06:59

targos · 2026-09-23T07:15:34Z

Looks like it should use this to support MSVC:

#if V8_CC_MSVC
  return _AddressOfReturnAddress();
#else
  return __builtin_frame_address(0);
#endif

Original commit message: [cppgc] Use _AddressOfReturnAddress() for StackStartMarker under MSVC include/cppgc/heap.h is a public header, and since b3cb54c7e65 ("[heap] Add StackStartMarker for cppgc") it calls __builtin_frame_address(0) unconditionally. That builtin does not exist in MSVC, so any translation unit built with cl.exe that includes the header (directly or through v8-cppgc.h) fails to compile, even if it never constructs a StackStartMarker. Use _AddressOfReturnAddress() when V8_CC_MSVC is set, which is what base::Stack::GetCurrentStackPosition() already does for the same purpose, and keep __builtin_frame_address(0) elsewhere. Bug: none Change-Id: Icd4c0238cb277c8e1b73454534ffb2519b302ce9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8361192 Reviewed-by: Omer Katz <omerkatz@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Commit-Queue: Shelley Vohr <shelley.vohr@gmail.com> Cr-Commit-Position: refs/heads/main@{#109737} Refs: v8/v8@5404e0f

joyeecheung · 2026-09-23T13:36:19Z

Backported https://chromium-review.googlesource.com/c/v8/v8/+/8361192

nodejs-github-bot · 2026-09-23T13:38:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/77797/

targos changed the title ~~deps: update V8 to 15.2.124.7~~ deps: update V8 to 15.2 Aug 9, 2026

nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. dependencies PRs that add, update, or configure Node.js dependencies. needs-ci PRs that need a full CI run. labels Aug 9, 2026

targos mentioned this pull request Aug 9, 2026

deps: update V8 to 14.9 #64784

Closed

targos force-pushed the v8-152 branch from 67173bd to 52dcedd Compare August 13, 2026 12:15

This was referenced Aug 18, 2026

module: change return type for ModuleWrap::SyntheticModuleEvaluationStepsCallback #65375

Open

build,src: make --use-largepages a no-op #65389

Merged

sxa mentioned this pull request Aug 20, 2026

RISC-V: "Illegal instruction" crash when vector instructions detected by V8 #64538

Open

joyeecheung force-pushed the v8-152 branch from 6bb8632 to a730d63 Compare August 21, 2026 17:36

joyeecheung and others added 20 commits September 22, 2026 20:39

build: disable v8_postmortem_support

7676368

Post-mortem libraries should use v8's debug_helper library instead. Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

src: migrate from deprecated xxxV2 APIs

c7a9f90

- Set/GetPrototype - Holder Signed-Off-By: Michaël Zasso <targos@protonmail.com> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

src: migrate from v8::PropertyCallbackInfo<void>

56c2f27

Signed-Off-By: Michaël Zasso <targos@protonmail.com> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

test: update wpt Wasm jsapi expectations

108ca9a

Signed-Off-By: Michaël Zasso <targos@protonmail.com> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

test: update test-heapdump-vm-script.js for new version of V8

d5a8b7f

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

src: fix external reference registration for new CFunction lifetime

766bde0

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

build: fix cppgc_base perfetto source scraper

4182a3a

Signed-off-by: Chengzhong Wu <cwu631@bloomberg.net> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

build,win: fix

78a5a24

Signed-off-by: StefanStojanovic <stefan.stojanovic@janeasystems.com> Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>

joyeecheung force-pushed the v8-152 branch from 86a9fcf to 125d504 Compare September 22, 2026 19:42

richardlau mentioned this pull request Sep 23, 2026

v8: Node 26.9.0 crashes with Check failed: new_capacity > 0. when Error.stackTraceLimit is set above 357913941 with --trace-uncaught #66074

Open

eliau2005 mentioned this pull request Sep 23, 2026

deps: V8: backport 786c1c2d88d4 #66249

Open

Uh oh!

Conversation

targos commented Aug 9, 2026

Uh oh!

nodejs-github-bot commented Aug 9, 2026 • edited by targos Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Aug 9, 2026

Uh oh!

joyeecheung commented Aug 10, 2026

Uh oh!

richardlau commented Aug 13, 2026

Uh oh!

targos commented Aug 13, 2026

Uh oh!

targos commented Aug 13, 2026

Uh oh!

legendecas commented Aug 14, 2026

Uh oh!

targos commented Aug 14, 2026

Uh oh!

nodejs-github-bot commented Aug 14, 2026

Uh oh!

nodejs-github-bot commented Aug 14, 2026

Uh oh!

nodejs-github-bot commented Aug 14, 2026

Uh oh!

nodejs-github-bot commented Aug 14, 2026

Uh oh!

richardlau commented Aug 14, 2026

Uh oh!

miladfarca commented Aug 14, 2026

Uh oh!

joyeecheung commented Aug 19, 2026

Uh oh!

joyeecheung commented Aug 20, 2026

Uh oh!

nodejs-github-bot commented Sep 22, 2026

Uh oh!

joyeecheung commented Sep 22, 2026

Uh oh!

targos commented Sep 23, 2026

Uh oh!

targos commented Sep 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joyeecheung commented Sep 23, 2026

Uh oh!

nodejs-github-bot commented Sep 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

nodejs-github-bot commented Aug 9, 2026 •

edited by targos

Loading

targos commented Sep 23, 2026 •

edited

Loading