fs: add signal option to fs.stat() - #57775
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #57775 +/- ##
==========================================
- Coverage 90.24% 90.22% -0.02%
==========================================
Files 635 635
Lines 187588 187596 +8
Branches 36860 36858 -2
==========================================
- Hits 169292 169266 -26
- Misses 11060 11111 +51
+ Partials 7236 7219 -17
🚀 New features to boost your workflow:
|
291c8a6 to
911f8da
Compare
commented
Apr 6, 2025
thank you very much, I will be more careful with this, sometimes I make the wrong sentence 🙏 |
f9b0d0d to
9fcffb4
Compare
commented
Apr 11, 2025
left a comment
There was a problem hiding this comment.
Doesn't necessarily have to be in scope of this PR, but i think we'll also need signal option for Sync and Promises API of this function, and also for the lstat version; ideally within same semver-minor release so there's no discrepancy between these functions.
commented
Apr 13, 2025
|
@mertcanaltin ... can you please remove the merge commit from this and use rebase instead to catch it up? |
171a72d to
99ec837
Compare
commented
Apr 13, 2025
thank you I used rebase |
This comment was marked as outdated.
This comment was marked as outdated.
|
@Renegade334 Thanks for ping. opened #63142 with the actual listener wiring, and #63143 for lstat/fstat/promises parity. |
add signal option to fs.stat() for #57751