use v24.20.0 instead of v22.12.0 for checks. Enable musl on v22 - #4440
Conversation
4808805 to
b79a7d5
Compare
Signed-off-by: Stewart X Addison <sxa@ibm.com>
sxa
changed the title
|
FYI @juanarbol since we should aim to release musl versions on v22.x as well as v24 and v26 as it will make the node-docker scripts less complex if we don't have to handle different conditions, and nodejs/node#63737 did not intend to restrict it to a subset of the active release lines. |
| // Alpine/musl ------------------------------------------- | ||
| [ /alpine-x64/, releaseType, lt(24) ], // Only release on v24+ for now pending test changes | ||
| [ /alpine-x64/, releaseType, lt(22) ], |
There was a problem hiding this comment.
Everything below 22 is EoL so this can be deleted.
There was a problem hiding this comment.
I'll be completely honest I left that in purely because after spotting that there was one other lt(22) clause in the file on one of the shared library selectors.
But I agree so have now removed it.
Signed-off-by: Stewart X Addison <sxa@ibm.com>
|
Now that the 26.8.1 release is out with Alpine this could be updated to that version (and the sizes fixed!) to give longer use of the tests on a live version but that can be done in a separate update and the important thing here is to add the v22 support to the release pipeline. |
2 participants
Update tests to use v24.20.0 which has been published with musl and update v22.x so it expects the musl versions too.
This is required because the currently published v22.12.0 used for the tests caused problems when the tests were inconsistent with the version being checked. Now that a version with musl is published we can make this change.
Follow up to #4428
Noting that the file sizes in the files are not correct, but they were not correct for v22.12.0 so are not verified by the checks.