Add new TLS tests to all driver API system tests - #2214
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## master #2214 +/- ##
===========================================
- Coverage 88.13% 71.94% -16.19%
===========================================
Files 88 32 -56
Lines 22828 4959 -17869
===========================================
- Hits 20119 3568 -16551
+ Misses 2709 1391 -1318
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ryanwixon-emerson
marked this pull request as ready for review
September 18, 2026 20:21
ryanwixon-emerson
requested review from
marcoskirsch,
ni-jfitzger and
vnktshr21
as code owners
September 18, 2026 20:21
ni-jfitzger
reviewed
Sep 20, 2026
Collaborator
|
Might be worth including |
ni-jfitzger
reviewed
Sep 21, 2026
ni-jfitzger
reviewed
Sep 21, 2026
Collaborator
|
Overall, this looks pretty good. |
ni-jfitzger
approved these changes
Sep 22, 2026
ni-jfitzger
changed the title
marcoskirsch
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contribution adheres to CONTRIBUTING.md.
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull request
What does this Pull Request accomplish?
This PR implements TLS-enabled gRPC tests for every driver API which includes
grpc-devicerelated testing:nidcpowernidigitalnifgennirfsanirfsgniscopeniswitchThe implementations follow the pattern first established by the trial driver, NI-DMM, in a previous PR (#2208):
BasicValidationTestsclassni-tls-configenabled workflows (one for enabled mTLS and one for disabled mTLS)(This PR also makes a minor change to the NI-DMM tests by adding the self test function to the
BasicValidationTestsclass. This is to bring it in line with these drivers, since I decided that it would be a good idea for everything to run it as a part of all of their tests).List issues fixed by this Pull Request below, if any.
N/A - This PR does not address any issues.
What testing has been done?
The PR CI pipelines successfully ran and indicated that the new tests are running correctly. This is sufficient because the implementation details are identical to that of NI-DMM, which was thoroughly tested with Wireshark to validate that the tests are using the proper TLS configurations and use real encrypted communication.