docs: complete the marketplace setup steps - #181
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe README adds the Claude Code plugin installation command. It also documents direct Git clone installation under Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The installation documentation adds Marketplace and direct-clone setup instructions without changing runtime behavior. The documented identifiers and repository layout align with the supplied metadata context, so the change is ready to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
The README named the catalog correctly but stopped one step short: it never
documented the `/plugin install` line, so following it left you with a
registered marketplace and no plugin. The install target is the catalog entry
name `github-project`, which is not always the repo name.
Also documents the marketplace-free route from Claude Code 2.1.157 ("Plugins in
.claude/skills directories are now automatically loaded, no marketplace
required"), which loads hooks, agents and commands in place.
Canonical template corrected in netresearch/skill-repo-skill#291.
Assisted-by: claude-code:claude-opus-5
Agent-Session: https://claude.ai/code/session_01L94yEWSBvuUkLqLpVbMqRh
Agent-Host: 0493f0
Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
89e3daa to
9dc35e1
Compare
Review on this PR found four defects in the section it adds: - The limitation note sat inside the `bash` fence under "Git Clone", so it rendered as shell input and would be copied along with the command. It now sits after the npx example, which is what it is about. - `git clone` into `~/.claude/skills/<name>` fails on a fresh setup where that parent does not exist; `mkdir -p ~/.claude/skills` precedes it. - "Update with `git pull`" ran wherever the reader happened to stand. It now names the directory and says a new session is needed for the change to load. - The sentence claimed hooks and commands unconditionally. It now names only what this repository actually ships. The skills-directory route itself is kept. The review argued it should be dropped because `.claude-plugin/plugin.json` lists only `skills`, but that key is not how hooks are discovered: of twelve installed plugins carrying a `hooks/` directory — Anthropic's own among them — none declares `hooks` in its `plugin.json`. `hooks/hooks.json` is loaded by convention, so its absence from the manifest proves nothing. Assisted-by: claude-code:claude-opus-5 Agent-Session: https://claude.ai/code/session_01Gcm3GRuYBxJGtyj7qviJF8 Agent-Host: 0493f0 Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
|
|
Copilot review unavailable — self-review below. The What this change is. A six-line correction to the install section, identical in shape across the rollout: the limitation note moved out of the How it was verified. The edit was produced by a script that asserts every anchor before replacing it, so a missed anchor aborts instead of silently doing nothing, and its output was compared byte-for-byte against a diff written and reviewed by hand first. The per-repository component sentence was cross-checked against the actual presence of One finding was declined, with evidence. The review argued the skills-directory route should not be published, because Scope of this attestation. One review of one change applied across the repositories that carry it, not twenty independent reviews. The diffs differ only in the repository name and the component list, and both were checked per repository. |
|
Self-review: e139f67 The review this pull request demands is unsatisfiable (Copilot quota wall or repeated bot failures on this head). Per the documented fallback, the diff on this head was reviewed by the PR author; this comment is the on-the-record attestation the merge gate reads back. It stops matching on the next push. |



The README named the catalog correctly, but stopped one step short of a working setup: it documented
/plugin marketplace add netresearch/claude-code-marketplaceand never the/plugin installline that has to follow it. Following it left you with a registered marketplace and no plugin.The install target is the catalog entry name —
github-projecthere — which is not always the repo name, and the right-hand side is the marketplace name rather thanowner/repo.Also added
The marketplace-free route, which is supported rather than a workaround. Claude Code 2.1.157: "Plugins in
.claude/skillsdirectories are now automatically loaded, no marketplace required." A clone under~/.claude/skills/github-projectloads asgithub-project@skills-dirwith hooks, agents and commands intact.Context
This came out of netresearch/retro-skill#90, where a user found the documented steps unusable. That repo pointed
marketplace addat itself, which fails outright; this repo was never broken, only incomplete. The shared template both came from is fixed in netresearch/skill-repo-skill#291.markdownlint-cli2clean.Review round
Review on this PR found four defects in the section above, all fixed here:
bashfence under "Git Clone", so it rendered as shell input and would be copied along with the command. It now follows the npx example, which is what it is about.git cloneinto~/.claude/skills/<name>fails on a fresh setup where that parent does not exist.mkdir -p ~/.claude/skillsprecedes it.git pull" ran wherever the reader happened to stand. It now names the directory and says a new session is needed for the change to load.One finding was declined: that the skills-directory route should not be published, because
.claude-plugin/plugin.jsonlists onlyskills.hooks/hooks.jsonis discovered by convention rather than declared — of twelve installed plugins carrying ahooks/directory, Anthropic's own included, none declares ahookskey. The key's absence proves nothing, so the route stays.Assisted by claude-code:claude-opus-5 — Session