Fix/row actions conditional hook - #642
Merged
Merged
Conversation
The actions column memo sat after an early return, so a table that lost its last row action called one hook fewer on the next render. React reported a change in the order of hooks and then threw "Should have a queue", taking the table down. A dashboard card that lets the user turn row actions off hits this on the toggle. The empty check moves inside the memo, which matches how the row selection column already handles being disabled, so the hook count no longer depends on how many actions a caller supplies.
A hidden action returned before reaching its props memo, so an action that became visible called one hook more than on the previous render and React threw "Rendered more hooks than during the previous render". Entering edit mode on a dashboard flips the visibility of an alert action and takes the whole table down with it. The visibility check moves below the memo, so the hook count no longer depends on whether an action is currently shown.
kapantzak
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.