Skip to content

Fix/row actions conditional hook - #642

Merged
novykh merged 3 commits into
masterfrom
fix/row-actions-conditional-hook
Sep 18, 2026
Merged

novykh merged 3 commits into
masterfrom
fix/row-actions-conditional-hook

Conversation

@novykh

@novykh novykh commented Sep 18, 2026

Copy link
Copy Markdown
Member

No description provided.

The actions column memo sat after an early return, so a table that lost its
last row action called one hook fewer on the next render. React reported a
change in the order of hooks and then threw "Should have a queue", taking the
table down. A dashboard card that lets the user turn row actions off hits this
on the toggle.

The empty check moves inside the memo, which matches how the row selection
column already handles being disabled, so the hook count no longer depends on
how many actions a caller supplies.
A hidden action returned before reaching its props memo, so an action that
became visible called one hook more than on the previous render and React
threw "Rendered more hooks than during the previous render". Entering edit
mode on a dashboard flips the visibility of an alert action and takes the
whole table down with it.

The visibility check moves below the memo, so the hook count no longer
depends on whether an action is currently shown.
@novykh
novykh merged commit 1eb8ae0 into master Sep 18, 2026
3 checks passed
@novykh
novykh deleted the fix/row-actions-conditional-hook branch September 18, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants