Styling layout ux polish part 1 - #641
Open
christophidesp wants to merge 9 commits into
Open
christophidesp wants to merge 9 commits into
christophidesp wants to merge 9 commits into
Conversation
kapantzak
force-pushed
the
styling-layout-ux-polish
branch
from
September 18, 2026 16:01
d5fdaff to
9546911
Compare
Align assertions and snapshots with the theme changes in this branch: mainBackground grey195 -> white, warning yellow80 -> yellow70, border grey185 -> grey180, tab backgrounds transparent in the light theme and menuItem -> tabItem for tab labels. Also flip the panelBgGrad expectation to match the implementation, where the gradient edges are panelBg and the centre is mainBackground.
kapantzak
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Theme colors (light and dark)
mainBackgroundand inputs are white, borders are one step darker, andpanelBgandtopBarBgare lighter.tabActiveBackgroundandtabItemkeep tabs green.panelBgGradis a horizontal gradient. The background mixin outputsbackground:for gradient values, so it works as a prop.yellow80(#FF9700) →yellow70(#DF8400) in light,yellow60(#BF7100) in dark.dropdownTablewas removed.Table
borderedprop (defaulttrue) turns the border off.[2, 4]padding.panelBgbackground and a fixed 40px height.tableRowBgHover.columnsicon with a "Columns" tooltip, and adds acolumnVisibilityFlavour="hollow"prop.aria-expandedwhile its menu is open.Button
inputBorderHoverfor the hover and active border, instead ofprimary.aria-expanded="true"applies the active styles, so a button looks pressed while its dropdown is open.Dropdowns, tabs and select
dropdownStyles.jsexportsdropdownBorderanddropdownRound. AnyDropwithbackground="dropdown"gets a border and rounding by default.[0, 4]; vertical (column) tabs keep[0, 0.5].-1pxbottom margin was removed.menuItemHover.Icons
add_more_charts,columns,dashboard_importandnav_reset.Dependency: https://github.com/netdata/cloud-frontend/pull/5793