Skip to content

App start. Show the window only when content is ready - #34688

Open
Eism wants to merge 2 commits into
musescore:mainfrom
Eism:app_start_fix
Open

App start. Show the window only when content is ready#34688
Eism wants to merge 2 commits into
musescore:mainfrom
Eism:app_start_fix

Conversation

@Eism

@Eism Eism commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Resolves: #33596
Resolves: #32612

It is the third option from #32612

Depends on musescore/muse_framework#247

@Eism
Eism requested a review from igorkorsukov August 24, 2026 13:23
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 0baa5cbe-d60a-4ba5-840e-3fe017b0cf04

📥 Commits

Reviewing files that changed from the base of the PR and between 28a192f and 030af3c.

📒 Files selected for processing (5)
  • muse
  • src/app/internal/guiapp.cpp
  • src/app/internal/guiapp.h
  • src/appshell/qml/MuseScore/AppShell/AppWindow.qml
  • src/appshell/qml/MuseScore/AppShell/WindowContent.qml

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The startup flow now defers splash-screen cleanup until the first dock page change. MuseScoreGuiApp uses Asyncable and provides closeSplash(). The application window starts with zero opacity and becomes fully visible after the page loads, before interactiveProvider.onPageOpened() runs. The muse submodule reference also changes to a newer commit.

Merge Risk: 🔵 Low · up to 030af

During first-page startup, the window may remain transparent if splash cleanup runs before content finishes restoring visibility. The PR is otherwise mergeable with explicit owner follow-up to make splash cleanup depend on completed page loading.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description references both issues and the dependency but omits the required checklist and a clear change motivation. Complete the required checklist and add a short description of the startup problem, implementation, and testing performed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the startup change: show the main window only after content is ready.
Linked Issues check ✅ Passed The changes implement option three from issue #32612 and address the startup window behavior described in issues #32612 and #33596.
Out of Scope Changes check ✅ Passed The changed files support the linked startup objectives, and the muse submodule update is consistent with the stated framework dependency.
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Linked repositories: Public OSS repositories can only analyze public repositories installed in this organization. No linked repositories were analyzed; skipped musescore/muse_framework.git.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DmitryArefiev DmitryArefiev self-assigned this Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants