fix #186: segmentation fault when unserializing nonexistent enum case - #187
Open
cracksalad wants to merge 1 commit into
Open
fix #186: segmentation fault when unserializing nonexistent enum case#187cracksalad wants to merge 1 commit into
cracksalad wants to merge 1 commit into
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #187 +/- ##
==========================================
+ Coverage 68.51% 68.59% +0.07%
==========================================
Files 7 7
Lines 1350 1366 +16
Branches 247 250 +3
==========================================
+ Hits 925 937 +12
- Misses 310 313 +3
- Partials 115 116 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186.
Add checks if the specified enum case exists and is an actual case (rather than a constant). This leads to 3 new warning cases, which are tested by 3 new test cases.