Skip to content

Split can now be nested with added class - #1115

Open
stephaniehobson wants to merge 1 commit into
mainfrom
nest-split
Open

stephaniehobson wants to merge 1 commit into
mainfrom
nest-split

Conversation

@stephaniehobson

Copy link
Copy Markdown
Contributor

Description

Adds a class that removes the left and right padding from the split component, so it can be nested in a content container.

  • I have documented this change in the design system.
  • I have recorded this change in CHANGELOG.md.

Issue

Add a link to a related GitHub issue if applicable.

Testing

See it in action http://localhost:3000/components/detail/split--nested

@stephaniehobson stephaniehobson changed the title Split can now be nested with class Split can now be nested with added class Jan 23, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Document migration guidance for removing overflow-x: hidden, or keep that unrelated change out of the PR.

Pull request overview

Adds support for nesting the Split component within content containers without duplicated horizontal spacing.

Changes:

  • Adds nested Split example, configuration, and documentation.
  • Implements nested layout styling.
  • Removes Split horizontal overflow clipping and records the changes in the changelog.
File summaries
File Summary
components/split/split.config.yml Documents nested and no-space variants.
components/split/split--nested.html Adds nested Split example markup.
components/split/readme.md Documents nested usage.
CHANGELOG.md Records the Split changes.
assets/sass/protocol/components/_split.scss Adds nested layout styling and removes overflow clipping.
Review details

Suppressed comments (1)

CHANGELOG.md:55

  • This new entry introduces a separate breaking behavior change—removing overflow-x: hidden from every Split—but the PR description only covers nested support, and docs/02-usage/migration.md has no migration guidance for this removal (unlike the other Split removals). Please document the rationale and how consumers should handle horizontal overflow, or keep this unrelated change out of the PR.
* (breaking) Removed `overflow-x: hidden` from component (#1089)
  • Files reviewed: 5/5 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants