Split can now be nested with added class - #1115
Open
stephaniehobson wants to merge 1 commit into
Open
stephaniehobson wants to merge 1 commit into
stephaniehobson wants to merge 1 commit into
Conversation
stephaniehobson
force-pushed
the
nest-split
branch
from
January 23, 2026 17:25
9c55401 to
c89141b
Compare
There was a problem hiding this comment.
🔵 Needs a closer look
Document migration guidance for removing overflow-x: hidden, or keep that unrelated change out of the PR.
Pull request overview
Adds support for nesting the Split component within content containers without duplicated horizontal spacing.
Changes:
- Adds nested Split example, configuration, and documentation.
- Implements nested layout styling.
- Removes Split horizontal overflow clipping and records the changes in the changelog.
File summaries
| File | Summary |
|---|---|
components/split/split.config.yml |
Documents nested and no-space variants. |
components/split/split--nested.html |
Adds nested Split example markup. |
components/split/readme.md |
Documents nested usage. |
CHANGELOG.md |
Records the Split changes. |
assets/sass/protocol/components/_split.scss |
Adds nested layout styling and removes overflow clipping. |
Review details
Suppressed comments (1)
CHANGELOG.md:55
- This new entry introduces a separate breaking behavior change—removing
overflow-x: hiddenfrom every Split—but the PR description only covers nested support, anddocs/02-usage/migration.mdhas no migration guidance for this removal (unlike the other Split removals). Please document the rationale and how consumers should handle horizontal overflow, or keep this unrelated change out of the PR.
* (breaking) Removed `overflow-x: hidden` from component (#1089)
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a class that removes the left and right padding from the split component, so it can be nested in a content container.
CHANGELOG.md.Issue
Add a link to a related GitHub issue if applicable.
Testing
See it in action http://localhost:3000/components/detail/split--nested