fix(auth): let url origin decide protected resource metadata discovery - #1264
Open
DaleSeo wants to merge 1 commit into
Open
fix(auth): let url origin decide protected resource metadata discovery#1264DaleSeo wants to merge 1 commit into
DaleSeo wants to merge 1 commit into
Conversation
github-actions
Bot
added
T-core
DaleSeo
marked this pull request as ready for review
September 12, 2026 15:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Follow-up to PR #1204: a
.well-knownguess only rules itself out, while an advertised URL reports the error. Two cases were still ignoring the origin. Aresource_metadatapointer found in a.well-knowncandidate's401response was fetched asAdvertised. That meant a bad document could end discovery without trying the remaining candidates. It is now treated as aWellKnownGuess.Advertisedis reserved for the resource's own challenge.How Has This Been Tested?
Added tests
Breaking Changes
None
Types of changes
Checklist