chore: remove CODEOWNERS entries now enforced org-wide (ENG-2013) - #89
Merged
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Paths every repo shares (.github/, Dockerfile, Makefile, docker/, alembic/, pyproject.toml, ...) now require a @mindsdb/devops review through the org-level ruleset in mindsdb/terraform, so they leave this file. Anything specific to this repo stays here; the same ruleset enforces CODEOWNERS via require_code_owner_review. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
hamishfagg
force-pushed
the
hamish/eng-2013-remove-codeowners
branch
from
September 10, 2026 05:07
89ced64 to
3ef75c0
Compare
hamishfagg
changed the title
lucas-koontz
approved these changes
Sep 10, 2026
lucas-koontz
left a comment
lucas-koontz
left a comment
Contributor
There was a problem hiding this comment.
fyi: Reviewed the CODEOWNERS deletion and effective rules on main. The live organization baseline already requires DevOps approval for .github changes, so this removes duplicate ownership. Unit tests passed. The CLA check requires a contributor signature; that result is unrelated to this deletion.
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes
.github/CODEOWNERS. The org-level ruleset in mindsdb/terraform (newprod/global/github) requires a@mindsdb/devopsreview on the paths common to all repos, and enforces each repo's CODEOWNERS throughrequire_code_owner_review. So: shared paths leave this file, repo-specific ones stay.Removed:
Why
One org-wide policy in terraform for what every repo shares; CODEOWNERS for what only this repo needs. Neither duplicates the other.
Targets
main.🤖 Generated with Claude Code