Skip to content

Pinning right version for typing-extensions - #329

Merged
mindflayer merged 1 commit into
mainfrom
pin-right-version
Aug 26, 2026
Merged

Pinning right version for typing-extensions#329
mindflayer merged 1 commit into
mainfrom
pin-right-version

Conversation

@mindflayer

@mindflayer mindflayer commented Aug 26, 2026

Copy link
Copy Markdown
Owner

Fix for #328

Copilot AI lite review requested due to automatic review settings August 26, 2026 10:15
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.85%. Comparing base (2838574) to head (5a89c1d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   98.85%   98.85%           
=======================================
  Files          22       22           
  Lines        1224     1224           
=======================================
  Hits         1210     1210           
  Misses         14       14           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change is a low-risk dependency floor update consistent with current runtime imports of typing_extensions in the package.

Pull request overview

Updates the project’s runtime dependencies to require a minimum typing-extensions version that matches the typing features used in the codebase (e.g., Self, ParamSpec, TypeAlias, Buffer).

Changes:

  • Bumps typing-extensions from an unversioned dependency to typing-extensions>=4.6.0 in pyproject.toml.
File summaries
File Description
pyproject.toml Adds a minimum version constraint for typing-extensions to prevent missing-symbol import errors at runtime.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@mindflayer
mindflayer merged commit 3641550 into main Aug 26, 2026
13 checks passed
@mindflayer
mindflayer deleted the pin-right-version branch August 26, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants