Skip to content

Fix Windows process picker loading from ASAR - #1096

Open
Rich Chiodo (rchiodo) wants to merge 1 commit into
mainfrom
rchiodo-fix-process-picker-asar
Open

Fix Windows process picker loading from ASAR#1096
Rich Chiodo (rchiodo) wants to merge 1 commit into
mainfrom
rchiodo-fix-process-picker-asar

Conversation

@rchiodo

Copy link
Copy Markdown
Contributor

Summary

  • load @vscode/windows-process-tree from VS Code's packaged node_modules.asar layout
  • retain the physical node_modules fallback for development and older layouts
  • log native process-tree failures before falling back to WMIC
  • cover both module layouts with unit tests

Fixes #1095

Validation

  • exercised both loader paths against the emitted JavaScript
  • git diff --check

Full TypeScript and unit test execution was blocked locally by npm registry TLS handshake failures while restoring dependencies.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@rchiodo Rich Chiodo (rchiodo) added the bug Issue identified by VS Code Team member as probable bug label Sep 1, 2026
@rchiodo
Rich Chiodo (rchiodo) enabled auto-merge (squash) September 1, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue identified by VS Code Team member as probable bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attach process picker still hangs without WMIC because windows-process-tree loader misses node_modules.asar

1 participant