Skip to content

Retry authenticated user lookup after transient failures #8910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Alex Ross (alexr00) merged 3 commits into from
Aug 28, 2026
+31 −5
Merged

Retry authenticated user lookup after transient failures #8910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa934ba
Initial plan
Copilot Aug 27, 2026
72704f5
Retry transient repository metadata failures
Copilot Aug 27, 2026
bda36f1
Attestation commit
alexr00 Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions src/github/githubRepository.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,15 +437,22 @@ export class GitHubRepository extends Disposable {

Logger.debug(`Fetch metadata - enter`, this.id);
const { remote } = await this.ensure();
this._metadata = this.getMetadataForRepo(remote.owner, remote.repositoryName).catch(e => {
if ((getErrorCode(e) === '404') && !isSamlError(e) && !this._isInaccessible) {
this._isInaccessible = true;
Logger.warn(`Repository ${remote.owner}/${remote.repositoryName} from remote ${remote.remoteName} in workspace folder ${this.rootUri.fsPath} returned HTTP 404 and will be skipped for this session.`, this.id);
const metadata = this.getMetadataForRepo(remote.owner, remote.repositoryName).catch(e => {
if (this._metadata === metadata) {
if ((getErrorCode(e) === '404') && !isSamlError(e)) {
if (!this._isInaccessible) {
this._isInaccessible = true;
Logger.warn(`Repository ${remote.owner}/${remote.repositoryName} from remote ${remote.remoteName} in workspace folder ${this.rootUri.fsPath} returned HTTP 404 and will be skipped for this session.`, this.id);
}
} else {
this._metadata = undefined;
}
}
throw e;
});
this._metadata = metadata;
Logger.debug(`Fetch metadata ${remote.owner}/${remote.repositoryName} - done`, this.id);
return this._metadata;
return metadata;
}

/**
Expand Down
19 changes: 19 additions & 0 deletions src/test/github/githubRepository.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,25 @@ describe('GitHubRepository', function () {
});
});

describe('getMetadata', function () {
it('retries after a transient failure and caches the successful result', async function () {
const url = 'https://github.com/some/repo';
const remote = new GitHubRemote('origin', url, new Protocol(url), GitHubServerType.GitHubDotCom);
const repo = new GitHubRepository(1, remote, Uri.file('/workspaces/repo'), credentialStore, telemetry);
sinon.stub(repo, 'ensure').resolves(repo);
const fetchMetadata = sinon.stub(repo as any, 'getMetadataForRepo');
const error = new Error('Connect Timeout Error');
const metadata = { name: 'repo', owner: { login: 'some' } };
fetchMetadata.onFirstCall().rejects(error);
fetchMetadata.onSecondCall().resolves(metadata);

await assert.rejects(repo.getMetadata(), candidate => candidate === error);
assert.strictEqual(await repo.getMetadata(), metadata);
assert.strictEqual(await repo.getMetadata(), metadata);
assert.strictEqual(fetchMetadata.callCount, 2);
});
});

describe('resolveRemote', function () {
beforeEach(function () {
sinon.stub(credentialStore, 'isAuthenticated').returns(true);
Expand Down