Markup message support push - #1861
Open
Marvin Brouwer (Marvin-Brouwer) wants to merge 7 commits into
Open
Marvin Brouwer (Marvin-Brouwer) wants to merge 7 commits into
Marvin Brouwer (Marvin-Brouwer) wants to merge 7 commits into
Conversation
…age-server-protocol docs
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #1860.
3.18 added
MarkupContentdiagnostic messages, guarded bytextDocument.diagnostic.markupMessageSupport.The guarded
messagefield is onDiagnostic, which both the push and pull models use, but the capability only exists onDiagnosticClientCapabilities.So a push-only server has no way to negotiate it.
In #1860 Dirk Bäumer (@dbaeumer)'s preference was to mirror the property rather than reword the existing one:
Notes
@proposedto the pull capability.pullDiagnostics.mdin the specification has carried it since 3.18, but it was missing here and in the generated model. Happy to drop it if you'd rather keep that change separate.client.tsline is not a behaviour changeThe property is optional, so omitting it already means unsupported. It's there so that both capabilities carry the same comment and turn up together when the flag is eventually enabled; otherwise it's easy to flip the pull one and leave push behind.
contributing.mdcalls avscode-languageclientreference implementation desirable.There isn't one here because VS Code can't render markdown diagnostic messages yet (Allow diagnostics messages to have markdown (or formatted text) content vscode#54272, feature: Allow diagnostics messages to have markdown content vscode#214051), which is why
markupMessageSupportis hardcodedfalseon both paths.