chore(deps-dev): bump @types/glob from 7.2.0 to 9.0.0 - #1671
Open
dependabot[bot] wants to merge 2 commits into
Open
chore(deps-dev): bump @types/glob from 7.2.0 to 9.0.0#1671dependabot[bot] wants to merge 2 commits into
dependabot[bot] wants to merge 2 commits into
Conversation
dependabot
Bot
added
dependencies
dependabot
Bot
requested review from
Changyong Gong (chagong),
Sheng Chen (jdneo),
Jinbo Wang (testforstephen) and
wenyt (wenytang-ms)
as code owners
August 6, 2026 06:39
dependabot
Bot
added
dependencies
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/types/glob-9.0.0
branch
3 times, most recently
from
August 20, 2026 22:27
beebec7 to
b2aa03c
Compare
Contributor
|
Dependabot (@dependabot) rebase |
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/types/glob-9.0.0
branch
3 times, most recently
from
August 31, 2026 05:36
f26d341 to
9b28c85
Compare
Contributor
|
Dependabot (@dependabot) rebase |
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/types/glob-9.0.0
branch
3 times, most recently
from
September 3, 2026 06:59
1f9c276 to
aa6d501
Compare
Bumps [@types/glob](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/glob) from 7.2.0 to 9.0.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/glob) --- updated-dependencies: - dependency-name: "@types/glob" dependency-version: 9.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/npm_and_yarn/types/glob-9.0.0
branch
from
September 3, 2026 07:14
aa6d501 to
86a4100
Compare
Replace the deprecated @types/glob stub with glob and update test discovery to its Promise API. Align the documented Node requirement with the dependency and CI runtime. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Changyong Gong (chagong)
approved these changes
Sep 3, 2026
Changyong Gong (chagong)
left a comment
Changyong Gong (chagong)
left a comment
Contributor
There was a problem hiding this comment.
Approved: the deprecated type stub was replaced with glob's built-in types, the Promise API migration is covered by green cross-platform CI, and the Node requirement is aligned.
Copilot started reviewing on behalf of
Changyong Gong (chagong)
September 3, 2026 08:25
View session
There was a problem hiding this comment.
🟡 Changes recommended
The updated Mocha runner removed synchronous exception handling around mocha.run(...), which can cause crashes instead of a clean Promise rejection.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the repository’s glob usage and related metadata to align with newer glob package APIs/types, including adjusting Node.js version requirements.
Changes:
- Updated the test runner to use the modern
globnamed export and Promise-based API. - Updated development dependencies / lockfile to use
glob@^13and removed@types/glob. - Tightened documented and declared Node.js engine requirements.
File summaries
| File | Description |
|---|---|
| test/suite/index.ts | Switches to glob named export and async/await discovery of test files before running Mocha. |
| package.json | Updates engines.node and dev dependency set to include glob@^13 (and remove @types/glob). |
| package-lock.json | Reflects dependency tree changes for glob@13 and related transitive packages. |
| CONTRIBUTING.md | Updates contributor-facing Node.js prerequisite version text. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+22
to
31
| return new Promise((c, e) => { | ||
| // Run the mocha test | ||
| mocha.run((failures) => { | ||
| if (failures > 0) { | ||
| e(new Error(`${failures} tests failed.`)); | ||
| } else { | ||
| c(); | ||
| } | ||
| }); | ||
| }); |
| - [JDK](http://www.oracle.com/technetwork/java/javase/downloads/index.html), (version 11 or later) | ||
| - [VS Code](https://code.visualstudio.com/), (version 1.44.0 or later) | ||
| - [Node.JS](https://nodejs.org/en/), (>= 12.8.1) | ||
| - [Node.JS](https://nodejs.org/en/), (20 or >= 22) |
Comment on lines
23
to
26
| "engines": { | ||
| "vscode": "^1.95.0" | ||
| "vscode": "^1.95.0", | ||
| "node": "20 || >=22" | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @types/glob from 7.2.0 to 9.0.0.
Commits