Remove remnants of the recursiveIncludes.reduce option - #14761
Open
Colen Garoutte-Carson (Colengms) wants to merge 1 commit into
Open
Remove remnants of the recursiveIncludes.reduce option#14761Colen Garoutte-Carson (Colengms) wants to merge 1 commit into
recursiveIncludes.reduce option#14761Colen Garoutte-Carson (Colengms) wants to merge 1 commit into
Conversation
Colen Garoutte-Carson (Colengms)
requested a review
from a team
as a code owner
September 10, 2026 22:34
Copilot started reviewing on behalf of
Colen Garoutte-Carson (Colengms)
September 10, 2026 22:35
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Stale localized catalogs still retain removed recursiveIncludes.reduce entries.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Lite
Findings: 2
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
Extension/package.nls.json — Remove the obsolete option from localized message catalogs |
|
Extension/ui/settings.html — Remove obsolete recursive-reduce UI translations |
What changed in this PR
Removes the obsolete recursiveIncludes.reduce option from the extension UI, configuration typings, and package metadata.
Changes:
- Removes the settings UI control.
- Removes the TypeScript configuration property.
- Removes the contributed setting and English localization entry.
- Notes stale entries remaining in localized catalogs.
| File | Reviewed change |
|---|---|
Extension/ui/settings.html |
Removes the obsolete settings UI; localized UI tables still contain stale IDs. |
Extension/src/LanguageServer/configurations.ts |
Removes the configuration property. |
Extension/package.nls.json |
Removes the English localization entry; localized catalogs still contain the obsolete key. |
Extension/package.json |
Removes the contributed setting schema. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Removes some lingering remnants of the
recursiveIncludes.reduceoptionrecursiveIncludes.reducehad already been removed from thecpp_properties.jsonschema. The native process now implements recursive includes in an efficient manner that no longer requires a 'reduce' phase.