Skip to content

inktoolbar generated casing fix - #11638

Open
Nitin Chaudhary (Nitin-100) wants to merge 2 commits into
mainfrom
user/nitinc/inktoolbar-generated-casing-fix
Open

inktoolbar generated casing fix#11638
Nitin Chaudhary (Nitin-100) wants to merge 2 commits into
mainfrom
user/nitinc/inktoolbar-generated-casing-fix

Conversation

@Nitin-100

Copy link
Copy Markdown
Contributor

Fixes

Fixes #

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Description

Current Behavior

New Behavior

Customer Impact

Regression Potential

  • Low risk — isolated change, limited scope
  • Medium risk — touches shared components or public APIs
  • High risk — architectural or breaking API change

How Has This Been Tested?

  • I have performed a self-review of my own code
  • I have added tests to cover my changes
  • Existing tests pass locally

Screenshots (if appropriate)

@Nitin-100
Nitin Chaudhary (Nitin-100) requested a review from a team as a code owner August 25, 2026 09:09
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@microsoft-github-policy-service microsoft-github-policy-service Bot added the needs-triage Issue needs to be triaged by the area owners label Aug 25, 2026

@harshit7962 Harshit (harshit7962) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File renames, LGTM

Nitin Chaudhary added 2 commits August 25, 2026 21:16
DependencyPropertyCodeGen names its outputs after the runtimeclass (type.Name),
which is the shipped lowercase 'InkToolbar'. InkToolBar.vcxitems and the ADO
source (PR 16362875) already use lowercase, but these 31 committed
Generated/*.properties.* files kept the original capital 'InkToolBar' because
the ADO case-only rename did not propagate through the case-insensitive mirror.
On GitHub full builds this mismatch surfaces the generated files as churn.
Renaming to lowercase matches the generator output, the project references,
and ADO, so the churn stops.
Renames the controls/dev/InkToolBar folder and its files to lowercase
'InkToolbar' to match the shipped runtimeclass and the ADO source
(PR 16362875). Pure renames: project/include references already use the
lowercase name, so no content changes. Completes the mirror's dropped
case-only rename together with the generated-file casing fix.
@Nitin-100
Nitin Chaudhary (Nitin-100) force-pushed the user/nitinc/inktoolbar-generated-casing-fix branch from 0aa6337 to 52f1a88 Compare August 25, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-triage Issue needs to be triaged by the area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants