Document CancellationToken propagation through nested tools - #8094
Open
nicolasdmolina wants to merge 1 commit into
Open
Document CancellationToken propagation through nested tools#8094nicolasdmolina wants to merge 1 commit into
nicolasdmolina wants to merge 1 commit into
Conversation
Make the current forwarding contract explicit so callers pass the same token through message handlers, workbenches, and nested tool I/O instead of creating a disconnected token. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
nicolasdmolina please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Top-level cancellation can look successful while a nested tool keeps running if a new
CancellationTokenis created atsend_messageorStaticWorkbench.call_tool. This documents the current forwarding contract and adds a credential-free nested example plus tests.Callers must pass the same token instance through message handlers (
ctx.cancellation_token),Workbench.call_tool, nestedBaseTool.run_json, and in-flight I/O vialink_future. Omitting the token creates a separate cancellation boundary. Linked cancellation raisesasyncio.CancelledError;StaticWorkbench.call_tooldoes not convert that into aToolResulterror.Related issue number
Closes #8091
Checks
Made with Cursor