Skip to content

Skip object classification for shared type facts #64188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mateusz Burzyński (Andarist) wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −5
Open

Skip object classification for shared type facts #64188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions tsc/internal/checker/checker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31402,16 +31402,17 @@ func (c *Checker) getTypeFactsWorker(t *Type, callerOnlyNeeds TypeFacts) TypeFac
}
return TypeFactsTrueFacts
case flags&TypeFlagsObject != 0:
var possibleFacts TypeFacts
var possibleFacts, commonFacts TypeFacts
if c.strictNullChecks {
possibleFacts = TypeFactsEmptyObjectStrictFacts | TypeFactsFunctionStrictFacts | TypeFactsObjectStrictFacts
commonFacts = TypeFactsEmptyObjectStrictFacts & TypeFactsFunctionStrictFacts & TypeFactsObjectStrictFacts
} else {
possibleFacts = TypeFactsEmptyObjectFacts | TypeFactsFunctionFacts | TypeFactsObjectFacts
commonFacts = TypeFactsEmptyObjectFacts & TypeFactsFunctionFacts & TypeFactsObjectFacts
}
if (callerOnlyNeeds & possibleFacts) == 0 {
// If the caller doesn't care about any of the facts that we could possibly produce,
// return zero so we can skip resolving members.
return TypeFactsNone
if callerOnlyNeeds&(possibleFacts&^commonFacts) == 0 {
// If the requested facts don't distinguish between object kinds, skip classifying the object.
return commonFacts
}
switch {
case t.objectFlags&ObjectFlagsAnonymous != 0 && c.isEmptyObjectType(t):
Expand Down