Align object binding defaults with arrays - #64043
Open
Jake Bailey (jakebailey) wants to merge 2 commits into
Open
Align object binding defaults with arrays#64043Jake Bailey (jakebailey) wants to merge 2 commits into
Jake Bailey (jakebailey) wants to merge 2 commits into
Conversation
Object binding patterns with an object-literal parameter default only added missing elements that had their own initializer. Array patterns already add every missing element, so equivalent object and array parameters inferred different types and produced different diagnostics. Pad object literal defaults with every missing binding element in all source kinds. Report implicit any through the existing diagnostic path, which preserves normal checkJs suppression while making checked JS and TypeScript match array patterns. Add matrix coverage for object and array patterns in TypeScript, checked JavaScript, and unchecked JavaScript. Fixes microsoft#59920
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns object-destructuring defaults with array behavior, addressing #59920.
Changes:
- Pads missing object-binding properties as optional.
- Reports implicit
anyconsistently. - Adds compiler tests and baselines.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
tsc/internal/checker/checker.go |
Updates object-binding type inference. |
tsc/testdata/tests/cases/compiler/objectBindingPatternDefaultMissingElements.ts |
Adds regression coverage. |
tsc/testdata/baselines/reference/compiler/objectBindingPatternDefaultMissingElements.types |
Records inferred types. |
tsc/testdata/baselines/reference/compiler/objectBindingPatternDefaultMissingElements.symbols |
Records inferred symbols. |
tsc/testdata/baselines/reference/compiler/objectBindingPatternDefaultMissingElements.errors.txt |
Records diagnostics. |
tsc/testdata/baselines/reference/compiler/inferredRestTypeFixedOnce.errors.txt |
Updates implicit-any diagnostics. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+16921
to
+16923
| name := c.getPropertyNameFromBindingElement(e) | ||
| if name != ast.InternalSymbolNameMissing && c.getPropertyOfType(t, name) == nil { | ||
| missingElements = append(missingElements, e) |
Object binding padding now considers every missing binding element, but a rest binding does not name a source property. Treating it as a property synthesized an optional member with the rest variable name. That made the rest variable contain itself and produced a spurious implicit-any diagnostic. Skip rest elements before looking up missing properties, matching object binding-pattern inference. Add coverage for the inferred parameter and rest-variable types and for the remaining required binding diagnostic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59920
Implements Anders' suggestion in #59920 (comment)