Bump mdn BCD to 8.0.5 - #2557
Open
Adam Naji (Bashamega) wants to merge 3 commits into
Open
Adam Naji (Bashamega) wants to merge 3 commits into
Adam Naji (Bashamega) wants to merge 3 commits into
Conversation
Contributor
|
Thanks for the PR! This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged. |
| * | ||
| * [MDN Reference](https://developer.mozilla.org/docs/Web/API/ReadableStream/from_static) | ||
| */ | ||
| from(asyncIterable: never): ReadableStream; |
Contributor
There was a problem hiding this comment.
Now we need to deal with this
Contributor
Author
There was a problem hiding this comment.
I just made it never what it should be?
Contributor
There was a problem hiding this comment.
Something not never, likely AsyncIterable | Iterable per https://webidl.spec.whatwg.org/#js-async-iterable. And skip AsyncIterable where it's not available.
Contributor
Author
There was a problem hiding this comment.
Updated
Contributor
|
Please tell the version in the PR title |
Signed-off-by: Bashamega <adambashaahmednaji@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.