Update URL & Request & XMLHttpRequest interface to accept Location by Bashamega · Pull Request #2552 · microsoft/TypeScript-DOM-lib-generator

Adam Naji (Bashamega) · 2026-09-07T12:28:48Z

Also, I couldn't figure out how to override fetch

…ds across multiple baselines

github-actions · 2026-09-07T12:29:02Z

Thanks for the PR!

This section of the codebase is owned by Kagami Sascha Rosylight (@saschanaz) - if they write a comment saying "LGTM" then it will be merged.

Adam Naji (Bashamega) · 2026-09-07T12:33:49Z

Should i handle the fallback to WorkerLocation in the emitter or what should i do in this situation?

Adam Naji (Bashamega) · 2026-09-07T13:55:02Z

Sign in to view

+    method parse signatureIndex=0 {
+        param base overrideType="string | URL | Location"
+    }
+}


…iple baseline files

Signed-off-by: Bashamega <adambashaahmednaji@gmail.com>

半岛的蒟蒻bddjr (bddjr) · 2026-09-07T14:03:06Z

🤔It seems that we need to separately make webworker.generated.d.ts exempt from this change.
I don't know how to do that, so I didn't submit a PR.

Kagami Sascha Rosylight (saschanaz) · 2026-09-07T14:21:40Z

+
+interface URL {
+    constructor signatureIndex=0 {
+        param url overrideType="string | URL | Location"


Why not additionalTypes? 🤔

Because location is not supported in web worker, i don't know how to handle web worker

the exposure checker should autoremove them... but maybe we don't do that for additionalTypes? 🤔

…ethod parameters across multiple baseline files

Adam Naji (Bashamega) · 2026-09-07T16:16:46Z

It wasn't implemented, but I have added it Kagami Sascha Rosylight (@saschanaz)

Victor Turansky (turansky) · 2026-09-08T21:03:44Z

Also, I couldn't figure out how to override fetch

Adam Naji (@Bashamega) should it also affect Request in that case?

半岛的蒟蒻bddjr (bddjr) · 2026-09-09T00:58:22Z

should it also affect Request in that case?

yes

new Request(location)

…aseline files

Adam Naji (Bashamega) · 2026-09-10T14:37:09Z

I have updated it. What do you think Kagami Sascha Rosylight (@saschanaz)

半岛的蒟蒻bddjr (bddjr) · 2026-09-10T14:43:46Z

ChatGPT suggested adding the type for fetch(location) like this:

 inputfiles/overridingTypes.jsonc

 "WindowOrWorkerGlobalScope": {
     "methods": {
         "method": {
+            "fetch": {
+                "signature": {
+                    "0": {
+                        "param": [
+                            {
+                                "name": "input",
+                                "additionalTypes": ["Location"]
+                            }
+                        ]
+                    }
+                }
+            },
             ...

…e baseline files Signed-off-by: Bashamega <adambashaahmednaji@gmail.com>

Adam Naji (Bashamega) · 2026-09-10T14:58:14Z

Thanks for the help 半岛的蒟蒻bddjr (@bddjr) ... Updated

半岛的蒟蒻bddjr (bddjr) · 2026-09-10T15:17:30Z

Review by Gemini 3.8 Flash:

Thanks for working on this! A few findings during the review:

1. Typo in `inputfiles/patches/fetch.kdl`

In inputfiles/patches/fetch.kdl:

interface Request {
  constructor signatureIndex=0 {
    param input {
      additionalTypes input Location
    }
  }
}

input was accidentally included as a type in additionalTypes. It should be:

      additionalTypes Location

(It was silently stripped only because isKnownType("input") is false).

2. `filterAdditionalTypes` in `src/build/expose.ts` didn't actually affect parameters

In filterUnknownTypeFromSignature, param.push({ ...p, type: flattenType(filtered) }) spreads p rather than using the filtered additionalTypes from filtered[0]. In addition, deepClone returns early at method signatures and does not recurse into param directly.
As a result, additionalTypes on parameters remained unfiltered until isKnownType in emitter.ts.
To properly filter additionalTypes in expose.ts:

const additionalTypes = filterAdditionalTypes(p.additionalTypes, unexposedTypes);
param.push({
  ...p,
  type: flattenType(filtered),
  additionalTypes: additionalTypes?.length ? additionalTypes : undefined,
});

3. Supporting `WorkerLocation` in Web Workers

Regarding your question about WorkerLocation:

Should i handle the fallback to WorkerLocation in the emitter or what should i do in this situation?

Once expose.ts properly filters additionalTypes, we can simply specify:

additionalTypes Location WorkerLocation

For DOM lib: WorkerLocation is unexposed and filtered out $\rightarrow$ results in Location.
For Worker lib: Location is unexposed and filtered out $\rightarrow$ results in WorkerLocation.
This allows workers to naturally accept location without any special fallback in emitter.ts!

…for Location

…est and URL constructors, as well as fetch method signatures.

半岛的蒟蒻bddjr (bddjr) · 2026-09-10T16:05:39Z

Review by Gemini 3.8 Flash:

Nice work on adding WorkerLocation! The generated baselines look spot on now.

Just one architectural detail regarding src/build/expose.ts:

Currently, the changes in src/build/expose.ts are actually dead code because:

deepClone returns early on o.signature and never traverses down into param objects.
In filterUnknownTypeFromSignature, param.push({ ...p, type: flattenType(filtered) }) spreads p (the original param) rather than preserving filtered[0].additionalTypes.

The reason the baselines generated correctly is actually due to filter((t) => isKnownType(t)) in src/build/emitter.ts.

To clean this up, we have two options:

Option 1 (Recommended): Make expose.ts actually handle additionalTypes on parameters:

// In filterUnknownTypeFromSignature in src/build/expose.ts
const additionalTypes = filterAdditionalTypes(p.additionalTypes, unexposedTypes);
param.push({
  ...p,
  type: flattenType(filtered),
  additionalTypes: additionalTypes?.length ? additionalTypes : undefined,
});

(and remove the unreachable if (o.additionalTypes) at the top of deepClone).

Option 2: If filtering via isKnownType in emitter.ts is deemed sufficient, revert the changes in src/build/expose.ts completely so we don't leave unused code in expose.ts.

…itionalTypes, ensuring proper filtering and assignment based on unexposed types.

Adam Naji (Bashamega) · 2026-09-18T08:42:13Z

I have updated it 半岛的蒟蒻bddjr (@bddjr)
Can you please check it when you have time Kagami Sascha Rosylight (@saschanaz)
Thank you

Kagami Sascha Rosylight (saschanaz) · 2026-09-19T10:18:06Z

-        p.additionalTypes!.push("URL");
+        if (!p.additionalTypes!.includes("URL")) {
+          p.additionalTypes!.push("URL");
+        }


Why? Just don't add it in patch that case?

Kagami Sascha Rosylight (saschanaz) · 2026-09-19T10:19:35Z

+      allEnumsMap[type] ||
+      allTypedefsMap[type]
+    );
+  }


This is a wrong layer, this filter should belong to expose.ts where things are already happening

Kagami Sascha Rosylight (saschanaz) · 2026-09-19T10:20:59Z

+          type: flattenType(filtered),
+          additionalTypes: additionalTypes?.length
+            ? additionalTypes
+            : undefined,


Perhaps make filterAdditionalTypes return undefined if empty?

Kagami Sascha Rosylight (saschanaz) · 2026-09-19T10:29:45Z

+interface Request {
+  constructor signatureIndex=0 {
+    param input {
+      additionalTypes Location WorkerLocation


I wonder we could have something like acceptsUrl=#true for type and then the emitter could add Location/WorkerLocation based on the emission target 🤔, at the same line where URL is being added right now. Thoughts?

We will need to change a lot of other files is it worth it?
Also should this be similar to IDL?

We are doing this because IDL doesn't say whether URL is expected or not at all. I thought doing it would cause less files, any idea how much changes would be needed?

But we may need the additionalTypes feature in the future after all, so I'm going to accept this as-is

Will this mean we translate that property to jsonc and support it in the original parser? Or did I misunderstand?

There's no original parser? Not sure I understand

Adam Naji (Bashamega) · 2026-09-19T11:16:46Z

I have updated it

Kagami Sascha Rosylight (saschanaz) · 2026-09-19T11:28:52Z

LGTM, thanks!

github-actions · 2026-09-19T11:29:08Z

Merging because Kagami Sascha Rosylight (@saschanaz) is a code-owner of all the changes - thanks!

Update URL interface to accept Location type in constructor and metho…

587901f

…ds across multiple baselines

update

a20ff24

半岛的蒟蒻bddjr (bddjr) reviewed Sep 7, 2026

View reviewed changes

Update URL constructor signature to include Location type across mult…

ed0def1

…iple baseline files

Adam Naji (Bashamega) requested a review from 半岛的蒟蒻bddjr (bddjr) September 7, 2026 13:55

update

a2b7b8e

Signed-off-by: Bashamega <adambashaahmednaji@gmail.com>

Kagami Sascha Rosylight (saschanaz) reviewed Sep 7, 2026

View reviewed changes

Refactor URL interface to remove Location type from constructor and m…

1d50041

…ethod parameters across multiple baseline files

Update Request constructor to include Location type across multiple b…

956f2d4

…aseline files

Adam Naji (Bashamega) changed the title ~~Update URL & interface to accept Location XMLHttpRequest~~ Update URL & Request & XMLHttpRequest interface to accept Location Sep 10, 2026

Update fetch method signature to include Location type across multipl…

72209e0

…e baseline files Signed-off-by: Bashamega <adambashaahmednaji@gmail.com>

Adam Naji (Bashamega) added 2 commits September 10, 2026 18:24

Refactor Request constructor to simplify additionalTypes declaration …

b0bf0fe

…for Location

Update multiple baseline files to include WorkerLocation type in Requ…

1144edb

…est and URL constructors, as well as fetch method signatures.

Refactor deepFilterUnexposedTypes function to enhance handling of add…

dc5517c

…itionalTypes, ensuring proper filtering and assignment based on unexposed types.

半岛的蒟蒻bddjr (bddjr) approved these changes Sep 18, 2026

View reviewed changes

Kagami Sascha Rosylight (saschanaz) suggested changes Sep 19, 2026

View reviewed changes

updatey

5eff783

github-actions Bot merged commit 0082b1b into microsoft:main Sep 19, 2026
9 checks passed

Adam Naji (Bashamega) deleted the fix/location-issue branch September 19, 2026 11:29

Conversation

Adam Naji (Bashamega) commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 7, 2026

Uh oh!

Adam Naji (Bashamega) commented Sep 7, 2026

Uh oh!

This comment was marked as resolved.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Uh oh!

半岛的蒟蒻bddjr (bddjr) commented Sep 7, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Adam Naji (Bashamega) commented Sep 7, 2026

Uh oh!

Victor Turansky (turansky) commented Sep 8, 2026

Uh oh!

半岛的蒟蒻bddjr (bddjr) commented Sep 9, 2026

Uh oh!

Adam Naji (Bashamega) commented Sep 10, 2026

Uh oh!

半岛的蒟蒻bddjr (bddjr) commented Sep 10, 2026

Uh oh!

Adam Naji (Bashamega) commented Sep 10, 2026

Uh oh!

半岛的蒟蒻bddjr (bddjr) commented Sep 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1. Typo in inputfiles/patches/fetch.kdl

2. filterAdditionalTypes in src/build/expose.ts didn't actually affect parameters

3. Supporting WorkerLocation in Web Workers

Uh oh!

半岛的蒟蒻bddjr (bddjr) commented Sep 10, 2026

Uh oh!

Adam Naji (Bashamega) commented Sep 18, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Adam Naji (Bashamega) commented Sep 19, 2026

Uh oh!

Kagami Sascha Rosylight (saschanaz) commented Sep 19, 2026

Uh oh!

Uh oh!

github-actions Bot commented Sep 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Adam Naji (Bashamega) commented Sep 7, 2026 •

edited

Loading

半岛的蒟蒻bddjr (bddjr) commented Sep 10, 2026 •

edited

Loading

1. Typo in `inputfiles/patches/fetch.kdl`

2. `filterAdditionalTypes` in `src/build/expose.ts` didn't actually affect parameters

3. Supporting `WorkerLocation` in Web Workers