Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Explicitly deassert DTR and RTS after opening the WebSerial port.
Problem
On a Heltec WiFi LoRa 32 V2 (ESP32) running MeshCore Companion firmware v1.17.1-d929643 over CP2102 on Windows/Chrome, the WebSerial port opened successfully but the Companion handshake timed out.
The same behavior was independently reproduced in meshcore_py.
In meshcore_py, RTS was already explicitly deasserted, while DTR was not. Adding DTR = false alongside the existing RTS = false resolved the same APP_START / SELF_INFO handshake timeout.
A startup delay alone did not resolve the issue, and the connection continued to work after the delay was removed. This helped isolate DTR handling as the relevant factor.
Fix
After opening the WebSerial port at 115200 baud, explicitly set:
The actual code change is shown in the PR diff.
Validation
Tested with:
Before
After
Related validation
The equivalent control-line change was also tested independently in meshcore_py:
This confirms that the issue is related to serial control-line handling rather than firmware startup timing.
A separate upstream patch for meshcore_py will be submitted independently.
Scope
This patch is intentionally minimal and only changes WebSerial control-line handling.