Add isGPSDetected() capability probe to SensorManager - #3390
Merged
Merged
Conversation
Lets applications know whether a GPS was actually detected (EnvironmentSensorManager reports its gps_detected state), e.g. to hide GPS-dependent UI when no receiver is attached.
oltaco
approved these changes
Sep 14, 2026
Member
|
Looks good to me, and I think it would give us a cleaner way to do #3391 and could also help solve the issue raised here #3391 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENV_INCLUDE_GPS says a build can have GPS. It says nothing about whether one is actually attached, and there is no way for the app to ask.
Adds a virtual
isGPSDetected()to SensorManager, returning false by default, overridden in EnvironmentSensorManager to return its existinggps_detectedflag. Builds without GPS keep the default.