Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build-and-deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ on:
jobs:
build:
runs-on: ubuntu-22.04
if: github.event.repository.fork == false

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest we go with if: github.repository == 'mendix/docs' than if: github.event.repository.fork == false.

Mainly because the fork check reads from the event payload, which isn't present on every event type and in some cases, the job runs anyway. Meanwhile, github.repository is always available in the context, and is consistent with how we guard our other workflows.

The trade-off is that it hardcodes the repo name, so a rename or transfer means updating the workflow, which seems unlikely, in contrast to other scenarios.

outputs:
target: ${{ steps.env.outputs.target }}
concurrency:
Expand Down