Fix WebSocketMessage type contract - #1032
Open
pengpengyi92 wants to merge 1 commit into
Open
Conversation
pengpengyi92
requested review from
jbonzo,
justinpolygon,
kschoche,
lukeoleson,
mmoghaddam385 and
suever
as code owners
August 26, 2026 15:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebSocketMessageas the union of individual parsed event models instead of a new type over a listList[WebSocketMessage], matching the runtime parser outputRoot cause
parse_single()returns one event model, whileparse()returns a list. The previous alias represented a list itself, so callback annotations became a nestedList[WebSocketMessage]andparse_single()needed an unsafe cast to hide the mismatch.Validation
python -m unittest discover -s test_websocket(3 passed)mypy massive test_websocket(50 files, no issues)black --check massive test_websocketgit diff --checkThe REST suite could not start locally because its longest fixture path is corrupted by the Windows non-ASCII workspace path; all failures occurred while loading the same unrelated fixture before test execution. Upstream CI should provide the full Linux run.
Closes #1022