fix: correct SQLite column metadata types - #313
Open
huytdps13400 wants to merge 1 commit into
Open
Conversation
Compare declared SQLite types for equality and cover sync and async metadata mapping. Closes margelo#305.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
strcmp(...) == 0instead of treating non-equality as a matchBOOLEAN,FLOAT,INTEGER,TEXT,BLOB, and undeclared expressionsexecute()andexecuteAsync()This preserves the current exact-declaration contract. Affinity aliases such as
REAL,DOUBLE,VARCHAR(...), andINTremain outside the existing mapping and continue to fall back toNULL_VALUE.Verification
BOOLEANreported asNUMBER)bun run typecheck(all three workspaces)types.hppgit diff --checkCloses #305.