Skip to content

fix failing api failover tests #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukasIO merged 2 commits into from
Sep 4, 2026
Merged

fix failing api failover tests #803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61cc223
fix failing api failover tests
lukasIO Sep 3, 2026
3fd3d15
update readme
lukasIO Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ try:
wait_until_answered=True,
))
except api.SipCallError as e:
print(e) # e.g. "SIP call failed: 486 Busy Here (resource_exhausted)"
print(e) # e.g. "SIP call failed: 486 Busy Here (failed_precondition)"
if e.sip_status_code == 486:
... # busy
except api.ServerError as e:
Expand Down
2 changes: 1 addition & 1 deletion tests/api/test_livekitapi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -544,7 +544,7 @@ async def _sip_call_error(sip: dict, *, wait: bool = False):
def test_sip_busy():
err = asyncio.run(_sip_call_error({"code": 486, "status": "Busy Here"}))
assert isinstance(err, ServerError)
assert err.code == "resource_exhausted"
assert err.code == "failed_precondition"
assert err.sip_status_code == 486
assert err.sip_status == "Busy Here"
# printable representation makes the failure clear
Expand Down