Skip to content

fix: bound GitHub installation token refresh with a request timeout #4742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaspergrom merged 2 commits into from
Sep 23, 2026
+3 −0
Merged

fix: bound GitHub installation token refresh with a request timeout #4742

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29960b1
fix: bound GitHub installation token refresh with a request timeout
gaspergrom Sep 23, 2026
11eecc8
Merge branch 'main' into fix/github-installation-token-timeout
gaspergrom Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions services/libs/common_services/src/services/github.integration.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ async function refreshGithubInstallationToken(): Promise<string> {
Accept: 'application/vnd.github+json',
'X-GitHub-Api-Version': '2022-11-28',
},
// axios has no timeout by default; without one, a hung request never settles
// refreshPromise below, wedging every concurrent caller sharing it indefinitely.
timeout: 15_000,

@themarolt themarolt Sep 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK axios in node applies timeout via req.setTimeout, which is a socket idle timeout - it only gets armed once the socket connects and resets on every chunk. so DNS/connect stalls fall back to the OS connect timeout, and a slow-dripping response can run past 15s. should we add signal: AbortSignal.timeout(15_000) next to it for a hard wall-clock bound? that's what discovery/github.ts and discovery/http.ts already do (or am I missing something?)

Comment on lines +56 to +58
},
)

Expand Down
Loading