Skip to content

hamradio: always override the alloc_objs compat shims #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kuba-moo merged 1 commit into from
Sep 22, 2026
Merged

hamradio: always override the alloc_objs compat shims #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions include/hamradio_compat.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,24 @@
#include <linux/overflow.h>

/*
* Compat shims for kzalloc_obj/kmalloc_obj/kzalloc_objs/kmalloc_objs
* which were added in kernels newer than 6.x. If the kernel already
* has them (detected via __alloc_objs), skip the definitions.
* Compat shims for kzalloc_obj/kmalloc_obj/kzalloc_objs/kmalloc_objs,
* with an optional GFP argument (defaulting to GFP_KERNEL) that every
* call site in this tree relies on.
*
* Some vendor kernels (e.g. Raspberry Pi Foundation's 6.18.x) already
* backport __alloc_objs()/kmalloc_obj()/etc. natively, but with a
* mandatory GFP argument and no variadic default. Skipping our own
* definitions in that case (the previous "#ifndef __alloc_objs" guard)
* left the vendor's incompatible, GFP-mandatory macros in place and
* broke every 1-argument call site in this tree. Always #undef and
* redefine our own variadic versions instead of trusting whatever the
* host kernel provides.
*/
#ifndef __alloc_objs
#undef __alloc_objs
#undef kmalloc_obj
#undef kmalloc_objs
#undef kzalloc_obj
#undef kzalloc_objs

#define __default_gfp_compat(a, b, ...) b
#define default_gfp_compat(...) __default_gfp_compat(, ##__VA_ARGS__, GFP_KERNEL)
Expand All @@ -34,8 +47,6 @@
#define kzalloc_objs(P, COUNT, ...) \
__alloc_objs(kzalloc, default_gfp_compat(__VA_ARGS__), typeof(P), COUNT)

#endif /* __alloc_objs */

/*
* struct sockaddr_unsized was introduced in Linux 7.0 to replace struct sockaddr
* in proto_ops .bind/.connect callbacks. Map it to struct sockaddr on older kernels.
Expand Down