Skip to content

Add counterparty_features on Channel - #279

Merged
benthecarman merged 1 commit into
lightningdevkit:mainfrom
elnafateh:expose-counterparty-features
Sep 10, 2026
Merged

Add counterparty_features on Channel#279
benthecarman merged 1 commit into
lightningdevkit:mainfrom
elnafateh:expose-counterparty-features

Conversation

@elnafateh

@elnafateh elnafateh commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Part of #272 (2/2).
Expose counterparty_features to Channel, reusing the existing features_to_proto helper.

@ldk-reviews-bot

ldk-reviews-bot commented Sep 10, 2026

Copy link
Copy Markdown

I've assigned @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@elnafateh elnafateh changed the title Adds counterparty_features on Channel Add counterparty_features on Channel Sep 10, 2026
@benthecarman

Copy link
Copy Markdown
Collaborator

Can we just use 34 for now and change / update the other pr when it's ready

@elnafateh
elnafateh force-pushed the expose-counterparty-features branch from 4658979 to fe260f5 Compare September 10, 2026 21:11

@benthecarman benthecarman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@benthecarman
benthecarman merged commit 6c58964 into lightningdevkit:main Sep 10, 2026
11 checks passed
@elnafateh
elnafateh deleted the expose-counterparty-features branch September 10, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants