Harden local secret file handling - #269
Open
benthecarman wants to merge 2 commits into
Open
Conversation
Create new log files without group or world access so local users cannot read node activity under the standard process umask. This commit was created with assistance from Codex.
Require existing API key files to contain the same 32-byte key material that the daemon generates. Truncated files must not enable weak HMACs. This commit was created with assistance from Codex.
|
👋 Thanks for assigning @tankyleo as a reviewer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 small issues found by loupe
0600permissions.