Reject empty metrics credentials - #267
Closed
benthecarman wants to merge 1 commit into
Closed
Conversation
Reject configured empty usernames or passwords so Basic Auth cannot be enabled with a predictable empty credential pair. This commit was created with assistance from Codex.
|
I've assigned @TheBlueMatt as a reviewer! |
|
Why? |
Collaborator
Author
|
loupe flagged this and if a user sets this it is likely a misconfiguration. seems better to just throw an error |
|
No, loupe is dumb. The client shouldn't be enforcing these kinds of things. Even if we think its marginally better to we don't need a ton of code just to enforce random shit on the client-side that the server can deal with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject configured empty usernames or passwords so Basic Auth cannot be enabled with a predictable empty credential pair.
This commit was created with assistance from Codex.