feat(universe): major moons stay named across the Solar System - #511
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
From high over the Solar System, the moons disappeared completely: once a planet's moon orbits shrink below a readable size, every moon's circle and name faded out. Now each planet's major moons (Io, Europa, Ganymede, Callisto, Titan, Rhea, Titania, Triton and the rest of the sourced groups in
site/source/major-moons.json) follow the rule Earth already uses beside the Sun. A moon keeps its circle while that circle clears its planet's circle, and keeps only its name once its orbit collapses into the planet's circle. Names still compete for the shared label budget and collision space, so a crowded planet names fewer moons.The planner receives the list as
annotationLandmarks, next to the existing annotation priorities, through the universe runtime, the main-thread planner and the worker.Evidence and limits
Proves the change: a desktop capture at 1440×900 of
/sun/?overview=system(134 AU) on the local build. Io, Titan, Rhea, Titania, Umbriel and Triton are named beside their planets with no circles. Before the change, the same view named no moons. Europa, Ganymede, Callisto and Oberon lost the collision contest there to their planet, the Sun and neighbouring labels.Checks:
vitestonuniverse/world-context-planner,universe/prepared-world-context,universe/world-context-planner-clientandlabels(176 passed);tsc -p site.Not checked: the phone view (12-label budget) and intermediate zooms where a moon's circle clears its planet's circle.