chore: float dependency versions within major and update release-secrets action to v1.2.1 - #66
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
Author
|
@cursor review |
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
@cursor review |
kinyoklion
approved these changes
Sep 15, 2026
tanderson-ld
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Weekly SDK-examples sweep: the app's library dependencies now float within their current major version so routine patch/minor releases need no PR, plus a CI-only pin refresh.
app/build.gradledependency constraints changed from exact pins to Gradle ranges that keep today's version as the floor:launchdarkly-android-client-sdk:[5.16.0,6.0.0),androidx.core:core-ktx:[1.19.0,2.0.0),androidx.appcompat:appcompat:[1.8.0,2.0.0). They resolve to the same versions today (5.16.0 / 1.19.0 / 1.8.0), so this is behavior-neutral now and self-updating later.launchdarkly/gh-actions/actions/release-secretspinned SHA bumpedrelease-secrets-v1.2.0→v1.2.1, which moves the action toaws-actions/configure-aws-credentialsv6 (node24) — Dependabot does not track this subdirectory action, so it had been stale since 2024.actions/checkout,actions/setup-javaandandroid-emulator-runnerpins (they pointed at v4.2.2 / v4.7.1 / v2.38.0 while the SHAs are v7.0.1 / v6.0.0 / v2.38.0).com.android.libraryplugin versions andcompileSdk/minSdk/targetSdkare deliberately left pinned — they are toolchain/supply-chain pins, not library dependencies.actions/setup-javav6.0.1 intentionally left for Dependabot's 7-day cooldown window.Implementation details
Floating-constraint verification on this machine (Gradle 9.7.1, AGP 9.4.0, compileSdk 37, JDK 17):
./gradlew assembleDebug --refresh-dependenciessucceeded, and./gradlew :app:dependencies --configuration debugRuntimeClasspathshows the ranges resolving to the expected latest-within-major versions:Maven metadata confirms 5.16.0 is the newest 5.x SDK, 1.19.0 the newest
core-ktx1.x and 1.8.0 the newestappcompat1.x, so the ranges do not silently move today. Gradle's default dynamic-version cache is 24h, so CI picks up new releases within the major on the next day's run.End-to-end run:
./gradlew installDebugonto a local API 34google_apisx86_64 emulator with thehello-appsmobile key andhello-booleanflag key injected the same wayrun.ymldoes;uiautomator dumpreportedThe 'hello-boolean' feature flag evaluates to true.(keys were injected locally only and are not committed).Notes on the range idiom:
[5.16.0,6.0.0)is used rather than5.+because the latter has no floor and would allow versions below the current one. Gradle treats these ranges as dynamic versions; there is no committed lockfile in this repo, so nothing else needs regenerating. The README documents no dependency versions, so no prose changes were needed.Earlier in this branch: the
Runworkflow passes with the new release-secrets pin — theGet mobile key and flag keystep (v1.2.1) fetches the SSM parameters and the emulator step still asserts the flag is true. The first attempt on commit437f8d2hung in theRun on emulatorstep for over an hour (that step normally takes ~90s) and was left to time out; the identical rerun one64f630passed in ~3 minutes, so it was a runner-side emulator hang, not a regression.Deprecated-API check:
javap -voverlaunchdarkly-android-client-sdk-5.16.0shows none of the APIs the example uses (LDConfig.Builder(AutoEnvAttributes),mobileKey,LDContext.builder,LDClient.init(app, config, context, 5),LDClient.get,boolVariation,registerFeatureFlagListener) are deprecated.com.android.librarystays at 9.3.2 in the rootbuild.gradle: Dependabot's bump to 9.4.0 (#65) was closed with an ignore, so the mismatch withcom.android.application9.4.0 is deliberate. The plugin is declaredapply falseand no module applies it.Link to Devin session: https://app.devin.ai/sessions/b8de27d27c66438a931b0089cec22d72
Open in Devin Desktop: https://app.devin.ai/desktop/session/b8de27d27c66438a931b0089cec22d72?variant=devin
Note
Overview
Gradle library dependencies in
app/build.gradleswitch from fixed versions to major-bounded ranges ([floor, nextMajor)), so patch/minor updates within the current major can land without a PR while keeping today’s resolved versions unchanged.CI bumps
launchdarkly/gh-actionsrelease-secrets from v1.2.0 to v1.2.1 inrun.yml(AWS credential helper refresh). Workflow comments above pinnedactions/checkout,actions/setup-java, andandroid-emulator-runnerSHAs are corrected to match the versions already in use; action commit pins themselves are unchanged except release-secrets.Reviewed by Cursor Bugbot for commit 6e60cf9. Bugbot is set up for automated code reviews on this repo. Configure here.