Skip to content

feat(api): update API spec from langfuse/langfuse 619dbe3 - #1866

Merged
wochinge merged 1 commit into
mainfrom
api-spec-bot-619dbe3-34094557428-1
Sep 7, 2026
Merged

feat(api): update API spec from langfuse/langfuse 619dbe3#1866
wochinge merged 1 commit into
mainfrom
api-spec-bot-619dbe3-34094557428-1

Conversation

@langfuse-bot

@langfuse-bot langfuse-bot commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Greptile Summary

This PR regenerates the API surface after removal of the deprecated unstable evaluator and evaluation-rule APIs.

  • Removes the corresponding sync and async client accessors, public exports, models, and error handling.
  • Retains the unstable dashboard and dashboard-widget services.
  • Simplifies the remaining shared unstable error models.
  • Applies a documentation whitespace cleanup to the dataset-run item request model.

Confidence Score: 5/5

The PR appears safe to merge, with the deprecated unstable evaluator surface removed consistently and stable replacements still available.

No actionable failures remain: sync and async clients, package exports, service modules, models, and evaluator-specific errors were removed together without leaving internal references.

Reviews (1): Last reviewed commit: "feat(api): update API spec from langfuse..." | Re-trigger Greptile

Context used:

@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

@claude review

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

No review was started: this request came from a bot account. Manual reviews can only be requested by someone with write access to this repository. Ask a maintainer to comment @claude review, or have your automation post the comment from a user account with write access.

Tip: disable this comment in your organization's Code Review settings.

@wochinge
wochinge enabled auto-merge (squash) September 7, 2026 07:18

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — this is a mechanical regeneration of the auto-generated langfuse/api/unstable client that removes the evaluators/evaluation_rules submodules and the UnprocessableContentError type, plus a trivial docstring whitespace fix elsewhere.

What was reviewed: verified the __init__.py/client.py dynamic-import maps and lazy-attr getters no longer reference the removed evaluation_rules/evaluators/commons evaluator types or UnprocessableContentError (no dangling references found); confirmed the deletions are confined to files under the removed submodules' own types/ trees; confirmed the only non-generated-deletion change is a whitespace-only docstring fix in create_dataset_run_item_request.py.

Extended reasoning...

Overview

This PR is a Fern-generated SDK update (per the bot-authored title "update API spec from langfuse/langfuse 619dbe3") that removes the evaluation_rules and evaluators submodules from langfuse/api/unstable/, along with related commons types (filters, operators, output definitions, prompt variable mappings) and the UnprocessableContentError error type. The top-level __init__.py and client.py for the unstable package are updated to drop imports, lazy-import mappings, and client properties referencing these removed modules. The only hand-written-looking change is a one-line trailing-whitespace fix in a docstring in create_dataset_run_item_request.py.

Security risks

None. This is a pure deletion of generated API client bindings for endpoints that presumably no longer exist (or moved) in the upstream spec; no new logic, no auth/crypto/permission code, no user input handling introduced or altered.

Level of scrutiny

Low. The change is entirely within auto-generated code (Fern SDK generator output) with no CLAUDE.md-derived conventions to check, no hand-written business logic, and internal consistency (dynamic import maps, __init__.py re-exports, and the errors package all consistently drop references to the removed types) verified directly. The bug-hunting pass found no issues, consistent with the mechanical nature of the change.

Other factors

Verified there are no dangling references to the removed evaluation_rules/evaluators/UnprocessableContentError symbols anywhere in the updated unstable/__init__.py or client.py. Since this class of change (regenerated SDK bindings dropping unstable/experimental endpoints) is simple, mechanical, and self-contained, and no findings were reported, this meets the bar for approval without requiring human review.

@wochinge
wochinge disabled auto-merge September 7, 2026 07:24
@wochinge
wochinge merged commit 8786515 into main Sep 7, 2026
22 checks passed
@wochinge
wochinge deleted the api-spec-bot-619dbe3-34094557428-1 branch September 7, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants