Skip to content

fix(site): keep a refusal a browser would not store #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vishr merged 3 commits into from
Sep 6, 2026
Merged

fix(site): keep a refusal a browser would not store #157

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e8c425b
fix(site): keep a refusal a browser would not store
vishr Sep 6, 2026
1af0090
fix(site): make a withdrawal reach the tabs already open
vishr Sep 6, 2026
966a51b
Revert "fix(site): make a withdrawal reach the tabs already open"
vishr Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions site/src/components/Analytics.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,12 +121,17 @@ const enabled = Boolean(measurementId) && import.meta.env.PROD;
function readPreference() {
try {
var stored = window.localStorage.getItem(STORAGE_KEY);
return stored === "granted" || stored === "denied" ? stored : null;
if (stored === "granted" || stored === "denied") return stored;
} catch (_) {
// A locked-down browser throws on access rather than returning
// null. The in-memory answer still governs this page.
return memoryPreference;
// null.
}
// Storage had no answer, or would not give one. Either way the
// choice made on this page still governs it: a browser can let the
// read succeed and refuse the write — Safari's private mode and a
// full quota both do — and reading back null there would discard an
// explicit refusal and start measuring anyway.
return memoryPreference;
}

function writePreference(preference) {
Expand Down