Conversation
A route with a literal colon (written as `\:`) and a parameter route at the same tree position used the same `:` marker during insertion, so a parameter node could end up attached as a static child of its parent. Backtracking then treated it as a parameter that was never entered, panicking with `index out of range [-1]`; the reverse registration order left the escaped colon route unreachable. Insert parameters with an internal placeholder that can not collide with a literal `:`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3111
A route with a literal colon (written as
\:) and a parameter route at the same tree position used the same:marker during insertion, so a parameter node could end up attached as a static child of its parent. Backtracking then treated it as a parameter that was never entered, panicking withindex out of range [-1]; the reverse registration order left the escaped colon route unreachable.Insert parameters with an internal placeholder that can not collide with a literal
:.Added
TestRouterParam_escapeColonAndParamConflictcovering both registration orders.