Add a pinned Gemini ACP reference for fresh sessions - #380
Open
rgarcia wants to merge 3 commits into
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@google/gemini-cli0.58.0 with a dedicated frozen Bun lockfile in both browser images.This PR is based on
hypeship/acp-websocketatd5bf85d0e9455f5b53d480595f65f1f933370c68, not main.Validation
go test -race ./lib/agentproxy ./lib/wsproxywith pinned Pi, Gemini and acpremote runtimes enabled, including native Gemini initialization/authentication/fresh sessions, model/mode controls, idle cancellation and HTTP MCP initialization with bound headers without provider prompts.go vet ./....gemini-2.5-flashprompts per run. Verified native authentication, permission requests, shared/session-overridden stdio MCP, credential redaction, independent connections, config updates, failed preparation retention and native/MCP process cleanup. Rebuilt and reran after the final changes.agent-runtimestage build and 0.58.0 version verification (not full headful behavior).lib/devtoolsproxyChromium restart test's TempDir cleanup (directory not empty); the isolated rerun reproduced that cleanup failure. No unrelated test changes.Integration surface
Shared-file changes are limited to Gemini registration in
config.go/handler.go, the packaged catalog, two Dockerfiles, the CI runtime-install step and the README pointer. Revision/transport machinery and Pi adapter files are unchanged. All implementation, native runtime and acceptance-test additions are Gemini-specific.