Skip to content

Add a pinned Gemini ACP reference for fresh sessions - #380

Open
rgarcia wants to merge 3 commits into
hypeship/acp-websocketfrom
hypeship/acp-gemini-reference
Open

Add a pinned Gemini ACP reference for fresh sessions#380
rgarcia wants to merge 3 commits into
hypeship/acp-websocketfrom
hypeship/acp-gemini-reference

Conversation

@rgarcia

@rgarcia rgarcia commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Package @google/gemini-cli 0.58.0 with a dedicated frozen Bun lockfile in both browser images.
  • Add an independent Gemini preparer using the existing revision manager and ACP bridge, with declarative model/session-turn settings, explicit workspace trust, native MCP configuration and secret-free credential bindings.
  • Preserve independent connection process trees, last-ready revisions, optimistic If-Match writes and native state outside replaceable revisions.
  • Document new sessions only: reconnect, discovery, load, resume and history replay are unsupported. No adapter patch, conversation shim, session registry or prompt retry.

This PR is based on hypeship/acp-websocket at d5bf85d0e9455f5b53d480595f65f1f933370c68, not main.

Validation

  • Passed: go test -race ./lib/agentproxy ./lib/wsproxy with pinned Pi, Gemini and acpremote runtimes enabled, including native Gemini initialization/authentication/fresh sessions, model/mode controls, idle cancellation and HTTP MCP initialization with bound headers without provider prompts.
  • Passed: go vet ./....
  • Passed: full Linux amd64 headless image build and enabled packaged-image gate using four bounded gemini-2.5-flash prompts per run. Verified native authentication, permission requests, shared/session-overridden stdio MCP, credential redaction, independent connections, config updates, failed preparation retention and native/MCP process cleanup. Rebuilt and reran after the final changes.
  • Passed: headful agent-runtime stage build and 0.58.0 version verification (not full headful behavior).
  • Native validation exposed that all MCP transports require workspace trust; the preparer now rejects HTTP/SSE as well as stdio when trust is disabled.
  • Full non-e2e race suite: all packages passed except the existing lib/devtoolsproxy Chromium restart test's TempDir cleanup (directory not empty); the isolated rerun reproduced that cleanup failure. No unrelated test changes.
  • Not verified: full headful behavior, HTTP tool calls, SSE MCP interoperability, active-inference cancellation, inference after model switching, multimodal input or platform gateway/TLS integration. Restoration is intentionally unsupported and not tested.

Integration surface

Shared-file changes are limited to Gemini registration in config.go/handler.go, the packaged catalog, two Dockerfiles, the CI runtime-install step and the README pointer. Revision/transport machinery and Pi adapter files are unchanged. All implementation, native runtime and acceptance-test additions are Gemini-specific.

@socket-security

socket-security Bot commented Sep 9, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​@​google/​gemini-cli@​0.58.09910010098100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant