Support credential field labels - #263
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
rgarcia
approved these changes
Sep 18, 2026
rgarcia
left a comment
Contributor
There was a problem hiding this comment.
reviewed incrementally — looks good. credential labels remain display-only metadata, while stable field names continue to drive updates, state, and browser fills. tests cover SDK serialization, safe output, ordering, redaction, and labeled/unlabeled fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
rollout
kernel/kernel#4214 is deployed, and this PR now uses the published
kernel-go-sdk@v0.110.0release.testing
make testmake buildgit diff --checkNote
Low Risk
Display-metadata and SDK bump only; field names remain authoritative and existing secret redaction behavior is unchanged.
Overview
Adds optional human-readable
labelon vault credential field definitions while keepingnameas the stable key for collection state, updates, and browser fill.The CLI now passes labels through the kernel-go-sdk v0.110.0 credential create/update flow, includes
labelin filtered vault JSON output forspec.fields, and updates README plusvaults credentialshelp/examples to document label vs. name behavior. Tests and steering assertions cover labeled and unlabeled fields, definition order, and that public output still redacts sensitive values.Reviewed by Cursor Bugbot for commit 57c299b. Bugbot is set up for automated code reviews on this repo. Configure here.