Skip to content

Add credential vault commands and preview CLI binaries - #252

Open
rgarcia wants to merge 8 commits into
mainfrom
hypeship/vault-credentials
Open

Add credential vault commands and preview CLI binaries#252
rgarcia wants to merge 8 commits into
mainfrom
hypeship/vault-credentials

Conversation

@rgarcia

@rgarcia rgarcia commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

summary

  • Add credential create/update from bounded file/stdin JSON and collection operations using the pinned Go SDK preview. Share fill execution and strict outcome validation between card and credential items; accept --params or --spec-file, with type-specific field/URL/format validation.
  • Make the flow discoverable through vaults, credentials, items, invoke, and browser help. Steer description toward the recognizable site name and usernames/emails toward explicit sensitive: false; document empty-string updates as clears. Preserve readiness/version metadata while omitting stored credential values. Redact credential write errors and disable SDK retries.
  • Adapt card PATCH to the typed SDK request without changing provider behavior.
  • Build Linux/macOS/Windows amd64/arm64 preview archives and checksums in Actions. No stable release, npm, or Homebrew publication. See PREVIEW.md for download instructions.

preview dependency

Pins the immutable STLC Go preview ea40d26657db27467b038ffdb877ca52e3623097 with a module replacement. The staging repository requires authentication: CI uses a contents-read GitHub App token for module download only, disables module caching, and skips fork jobs. Replace the pin with a released SDK and remove temporary auth before merging or stable publication; the release workflow enforces this.

validation

  • make test (vet and all repository tests): pass.
  • Vault/credential/browser-binding tests under the race detector: pass.
  • Local CLI build and help inspection: pass.
  • actionlint for changed workflows and bash syntax validation: pass.
  • SDK HTTP contract tests cover typed requests, null and empty-string clearing, collection URLs, both fill input modes/item types, credential fields named expiration, safe outcomes, redaction, and no retries. Subprocess tests verify valid JSON and exit status for credential and card outcomes.
  • The CI-built Linux binary at b4a66ce starts and displays the new site-name/sensitivity guidance. All six archive checksums verify. Live browser fill has not been exercised.

try the preview

Download the CI preview binaries (GitHub login required, 14-day retention). Includes Linux/macOS/Windows on amd64 and arm64. Extraction and API configuration instructions are in PREVIEW.md.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f1e6a86. Configure here.

Comment thread cmd/vaults_output.go
@rgarcia
rgarcia requested a review from hiroTamada September 14, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant