Skip to content

[FileFormats.MOF] fix list of _SUPPORTED_VERSIONS #3091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
odow merged 3 commits into from
Sep 21, 2026
+48 −10
Merged

[FileFormats.MOF] fix list of _SUPPORTED_VERSIONS #3091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb2b2a2
[FileFormats.MOF] fix list of _SUPPORTED_VERSIONS
odow Sep 20, 2026
9bcc073
Update
odow Sep 20, 2026
4dad2b2
Update
odow Sep 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions docs/src/submodules/FileFormats/overview.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ MathOptInterface.Utilities.IndexMap with 1 entry:
julia> MOI.write_to_file(dest, "file.mof.json")

julia> print(read("file.mof.json", String))
{"name":"MathOptFormat Model","version":{"major":1,"minor":7},"variables":[{"name":"x1"}],"objective":{"sense":"feasibility"},"constraints":[]}
{"name":"MathOptFormat Model","version":{"major":1,"minor":9},"variables":[{"name":"x1"}],"objective":{"sense":"feasibility"},"constraints":[]}
```

## Read from file
Expand Down Expand Up @@ -244,10 +244,7 @@ Then, check if a model file is valid using `isvalid`:
```jldoctest schema_mof
julia> good_model = JSON.parse("""
{
"version": {
"major": 1,
"minor": 5
},
"version": {"major": 1, "minor": 9},
"variables": [{"name": "x"}],
"objective": {"sense": "feasibility"},
"constraints": []
Expand All @@ -263,10 +260,7 @@ validation fails:
```jldoctest schema_mof
julia> bad_model = JSON.parse("""
{
"version": {
"major": 1,
"minor": 5
},
"version": {"major": 1, "minor": 9},
"variables": [{"NaMe": "x"}],
"objective": {"sense": "feasibility"},
"constraints": []
Expand Down
2 changes: 2 additions & 0 deletions src/FileFormats/MOF/MOF.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ MathOptInterface.
const SCHEMA_PATH = joinpath(@__DIR__, "mof.schema.json")

const _SUPPORTED_VERSIONS = (
v"1.9",
v"1.8",
v"1.7",
v"1.6",
v"1.5",
Expand Down
2 changes: 1 addition & 1 deletion test/FileFormats/MOF/nlp.mof.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "MathOptFormat Model",
"version": {
"major": 1,
"minor": 7
"minor": 9
},
"variables": [
{
Expand Down
42 changes: 42 additions & 0 deletions test/FileFormats/MOF/test_MOF.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1691,6 +1691,48 @@ function test_unsupported_kwarg()
return
end

function test_v1_8()
io = IOBuffer(
"""
{
"version": {"major": 1, "minor": 8},
"variables": [{"name": "t"}, {"name": "x"}, {"name": "y"}],
"objective": {"sense": "feasibility"},
"constraints": [{
"function": {"type": "VectorOfVariables", "variables": ["t", "x", "y"]},
"set": {"type": "DualGeometricMeanCone", "dimension": 3}
}]
}
""",
)
model = MOI.FileFormats.MOF.Model()
read!(io, model)
ret = MOI.get(model, MOI.ListOfConstraintTypesPresent())
@test only(ret) == (MOI.VectorOfVariables, MOI.DualGeometricMeanCone)
return
end

function test_v1_9()
io = IOBuffer(
"""
{
"version": {"major": 1, "minor": 9},
"variables": [{"name": "u"}, {"name": "v"}, {"name": "w"}],
"objective": {"sense": "feasibility"},
"constraints": [{
"function": {"type": "VectorOfVariables", "variables": ["u", "v", "w"]},
"set": {"type": "DualRelativeEntropyCone", "dimension": 3}
}]
}
""",
)
model = MOI.FileFormats.MOF.Model()
read!(io, model)
ret = MOI.get(model, MOI.ListOfConstraintTypesPresent())
@test only(ret) == (MOI.VectorOfVariables, MOI.DualRelativeEntropyCone)
return
end

end

TestMOF.runtests()
Loading